ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html - Issue 2723403004: MD Settings: Internet details: Fix proxy toggle and polish

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html

Issue 2723403004: MD Settings: Internet details: Fix proxy toggle and polish (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_proxy.html ('K') | « chrome/browser/resources/settings/internet_page/network_proxy.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html

diff --git a/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html b/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html

index ded65ec70df3d25228df90cca58f3ea6ccc3fc46..29dd12242c60f2618f7ca0dc8789cc62efeaff70 100644

--- a/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html

+++ b/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html

@@ -17,10 +17,11 @@

}

</style>

- <iron-icon id="indicator" tabindex="0" hidden$="[[!indicatorVisible]]"

- icon="[[indicatorIcon]]">

+ <iron-icon id="indicator" tabindex="0" aria-describedby="tooltip"

Dan Beam 2017/03/04 02:25:55 this is gonna eventually need an aria-label as wel

stevenjb 2017/03/06 18:33:49 I don't quite follow; commented on the tissue. I w

+ hidden$="[[!indicatorVisible]]" icon="[[indicatorIcon]]">

</iron-icon>

- <paper-tooltip for="indicator" position="top" fit-to-visible-bounds>

+ <paper-tooltip id="tooltip" for="indicator" position="top"

+ fit-to-visible-bounds>

[[indicatorTooltip]]

</paper-tooltip>

</template>