third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h - Issue 2723313003: Revert of //third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2723313003: Revert of //third_party/WebKit/Source/bindings: include v8 as a user, not system, header (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

index 17d08c74f148512e7c4658abccb6ca99c46c430f..305bab8632d8c10ff2417c8c4d30df725a0ce13c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

@@ -26,8 +26,8 @@

#ifndef V8PerIsolateData_h

#define V8PerIsolateData_h

+#include <v8.h>

#include <memory>

#include "bindings/core/v8/ScopedPersistent.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/ScriptWrappableVisitor.h"

@@ -37,7 +37,6 @@

#include "gin/public/isolate_holder.h"

#include "gin/public/v8_idle_task_runner.h"

#include "platform/heap/Handle.h"

-#include "v8/include/v8.h"

#include "wtf/HashMap.h"

#include "wtf/Noncopyable.h"

#include "wtf/Vector.h"