[Sync] Implementation of model association for passwords using sync API

chrome/browser/password_manager/password_syncable_service.h

Index: chrome/browser/password_manager/password_syncable_service.h
diff --git a/chrome/browser/password_manager/password_syncable_service.h b/chrome/browser/password_manager/password_syncable_service.h
index dd32b2c323ab774c14fe583990b7c3724055809e..43831bffaa56650871a3b9f799ac79ab4f9df125 100644
--- a/chrome/browser/password_manager/password_syncable_service.h
+++ b/chrome/browser/password_manager/password_syncable_service.h
@@ -60,15 +60,32 @@ class PasswordSyncableService : public syncer::SyncableService {
                              const std::string& password_element,
                              const std::string& signon_realm);
 
+  // Converts the |PasswordForm| to |SyncData| suitable for syncing.

[Nicolas Zea, 2013/10/21 23:55:14]

nit: no need to mention suitable for syncing; that's implied by converting to
SyncData

[lipalani1, 2013/10/24 00:13:58]

Done.

+  static syncer::SyncData CreateSyncData(
+      const autofill::PasswordForm& password);

[Nicolas Zea, 2013/10/21 23:55:14]

nit: fix indent

[lipalani1, 2013/10/24 00:13:58]

Done.

+  static void ExtractPasswordFromSpecifics(
+     const sync_pb::PasswordSpecificsData& password,
+     autofill::PasswordForm* new_password);
+
  private:
   typedef std::vector<autofill::PasswordForm*> PasswordForms;
 
+  typedef std::map<std::string,

[Nicolas Zea, 2013/10/21 23:55:14]

nit: remove newline above

[lipalani1, 2013/10/24 00:13:58]

Done.

+                   std::pair<syncer::SyncChange::SyncChangeType,
+                             std::vector<autofill::PasswordForm*>::iterator > >
+      PasswordEntryMap;
+
   // Use the |PasswordStore| APIs to add and update entries.
   void WriteToPasswordStore(PasswordForms* new_entries,
                             PasswordForms* udpated_entries);
-
-  // Converts the |PasswordForm| to |SyncData| suitable for syncing.
-  syncer::SyncData CreateSyncData(const autofill::PasswordForm& password);
+  void CreateOrUpdateEntry(

[Nicolas Zea, 2013/10/21 23:55:14]

Comment about what function does

[lipalani1, 2013/10/24 00:13:58]

Done.

+      const syncer::SyncData& data,
+      PasswordEntryMap* loaded_data,
+      ScopedVector<autofill::PasswordForm>* new_entries,
+      ScopedVector<autofill::PasswordForm>* udpated_entries);

[Nicolas Zea, 2013/10/21 23:55:14]

udpated ->  updated

[lipalani1, 2013/10/24 00:13:58]

Done.

+
+  // Virtual so tests can override.
+  virtual void NotifyPasswordStore();
 
   // The factory that creates sync errors. |SyncError| has rich data
   // suitable for debugging.