Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: src/inspector/v8-debugger-agent-impl.cc

Issue 2723273002: [inspector] introduced Debugger.scheduleStepIntoAsync (Closed)
Patch Set: fixed tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.h ('k') | test/inspector/debugger/schedule-step-into-async.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-agent-impl.cc
diff --git a/src/inspector/v8-debugger-agent-impl.cc b/src/inspector/v8-debugger-agent-impl.cc
index 8b7521d974b0da1de2a6a62cf4054014f4471e04..bf7ddb46a57b6720a1da492513d808a9885c43d6 100644
--- a/src/inspector/v8-debugger-agent-impl.cc
+++ b/src/inspector/v8-debugger-agent-impl.cc
@@ -736,6 +736,28 @@ Response V8DebuggerAgentImpl::stepOut() {
return Response::OK();
}
+void V8DebuggerAgentImpl::scheduleStepIntoAsync(
+ std::unique_ptr<ScheduleStepIntoAsyncCallback> callback) {
+ if (!isPaused()) {
+ callback->sendFailure(Response::Error(kDebuggerNotPaused));
+ return;
+ }
+ if (m_stepIntoAsyncCallback) {
+ m_stepIntoAsyncCallback->sendFailure(Response::Error(
+ "Current scheduled step into async was overriden with new one."));
+ }
+ m_stepIntoAsyncCallback = std::move(callback);
+}
+
+bool V8DebuggerAgentImpl::shouldBreakInScheduledAsyncTask() {
+ if (!m_stepIntoAsyncCallback) return false;
+ m_stepIntoAsyncCallback->sendSuccess();
+ m_stepIntoAsyncCallback.reset();
+ m_scheduledDebuggerStep = NoStep;
+ v8::debug::ClearStepping(m_isolate);
+ return true;
+}
+
Response V8DebuggerAgentImpl::setPauseOnExceptions(
const String16& stringPauseState) {
if (!enabled()) return Response::Error(kDebuggerNotEnabled);
@@ -1226,6 +1248,12 @@ void V8DebuggerAgentImpl::didPause(int contextId,
breakAuxData->setArray("reasons", std::move(reasons));
}
+ if (m_stepIntoAsyncCallback) {
+ m_stepIntoAsyncCallback->sendFailure(
+ Response::Error("No async tasks were scheduled before pause."));
+ m_stepIntoAsyncCallback.reset();
+ }
+
std::unique_ptr<Array<CallFrame>> protocolCallFrames;
Response response = currentCallFrames(&protocolCallFrames);
if (!response.isSuccess()) protocolCallFrames = Array<CallFrame>::create();
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.h ('k') | test/inspector/debugger/schedule-step-into-async.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698