Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: ios/chrome/browser/tabs/tab.mm

Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang. (Closed)
Patch Set: update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/tabs/tab.h" 5 #import "ios/chrome/browser/tabs/tab.h"
6 6
7 #import <CoreLocation/CoreLocation.h> 7 #import <CoreLocation/CoreLocation.h>
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 1381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1392 return NO; 1392 return NO;
1393 } 1393 }
1394 1394
1395 - (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry { 1395 - (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry {
1396 [parentTabModel_ notifyTabChanged:self]; 1396 [parentTabModel_ notifyTabChanged:self];
1397 } 1397 }
1398 1398
1399 - (void)webState:(web::WebState*)webState 1399 - (void)webState:(web::WebState*)webState
1400 didFinishNavigation:(web::NavigationContext*)navigation { 1400 didFinishNavigation:(web::NavigationContext*)navigation {
1401 if (navigation->IsSamePage()) { 1401 if (navigation->IsSamePage()) {
1402 auto faviconDriver = favicon::WebFaviconDriver::FromWebState(webState); 1402 auto* faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);
1403 if (faviconDriver) { 1403 if (faviconDriver) {
1404 // Fetch the favicon for the new URL. 1404 // Fetch the favicon for the new URL.
1405 faviconDriver->FetchFavicon(navigation->GetUrl()); 1405 faviconDriver->FetchFavicon(navigation->GetUrl());
1406 } 1406 }
1407 } 1407 }
1408 [parentTabModel_ notifyTabChanged:self]; 1408 [parentTabModel_ notifyTabChanged:self];
1409 } 1409 }
1410 1410
1411 // Records the state (scroll position, form values, whatever can be 1411 // Records the state (scroll position, form values, whatever can be
1412 // harvested) from the current page into the current session entry. 1412 // harvested) from the current page into the current session entry.
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
2232 2232
2233 - (TabModel*)parentTabModel { 2233 - (TabModel*)parentTabModel {
2234 return parentTabModel_; 2234 return parentTabModel_;
2235 } 2235 }
2236 2236
2237 - (FormInputAccessoryViewController*)inputAccessoryViewController { 2237 - (FormInputAccessoryViewController*)inputAccessoryViewController {
2238 return inputAccessoryViewController_.get(); 2238 return inputAccessoryViewController_.get();
2239 } 2239 }
2240 2240
2241 @end 2241 @end
OLDNEW
« no previous file with comments | « build/config/clang/BUILD.gn ('k') | ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698