Cocoa Page Info: Take built-in padding into account for "Site settings" button placement.

chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
index dbbb27337ecda272f46c32a15125b5692bb45aed..d542f98d6904ca5d56e9711dcf259f91f2657f24 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
@@ -70,6 +70,9 @@ const CGFloat kSectionHorizontalPadding = 16;
 // align with other text.
 const CGFloat kLinkButtonXAdjustment = 1;
 
+// Built-in margin for NSButton to take into account.
+const CGFloat kNSButtonBuiltinMargin = 4;
+
 // Security Section ------------------------------------------------------------
 
 // Spacing between security summary, security details, and cert decisions text.
@@ -441,13 +444,13 @@ bool IsInternalURL(const GURL& url) {
 - (CGFloat)layoutViewAtRTLStart:(NSView*)view withYPosition:(CGFloat)yPos {
   CGFloat xPos;
   if (base::i18n::IsRTL()) {
-    xPos =
-        kDefaultWindowWidth - kSectionHorizontalPadding - NSWidth([view frame]);
+    xPos = kDefaultWindowWidth - kSectionHorizontalPadding -
+           NSWidth([view frame]) + kNSButtonBuiltinMargin;
   } else {
-    xPos = kSectionHorizontalPadding;
+    xPos = kSectionHorizontalPadding - kNSButtonBuiltinMargin;
   }
-  [view setFrameOrigin:NSMakePoint(xPos, yPos)];
-  return yPos + NSHeight([view frame]);
+  [view setFrameOrigin:NSMakePoint(xPos, yPos - kNSButtonBuiltinMargin)];
+  return yPos + NSHeight([view frame]) - kNSButtonBuiltinMargin;
 }
 
 // Set the Y position of |view| to the given position, and return the position