Issue 2723233002: Fix compiler warning with shift of negative value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2723233002: Fix compiler warning with shift of negative value. (Closed)

Created:
3 years, 9 months ago by Florian Schneider

Modified:
3 years, 9 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix compiler warning with shift of negative value. It seems newer versions of gcc complain about undefined behavior. Fixes #28923. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/67c42c7d102638fcc75d03b68d3ed3eb0b178dd6

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/flow_graph_range_analysis.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

3 years, 9 months ago (2017-03-01 18:47:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
67c42c7d102638fcc75d03b68d3ed3eb0b178dd6 (presubmit successful).