mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 272323003: Mojo: Implement support for |Foo&| mojom syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 272323003: Mojo: Implement support for |Foo&| mojom syntax (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/sample_service.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index e0b74f903f16e64fc541e20d0efb2c0d522ba4a7..762d1617899e82226eb3ef78e6271f08c0989ab0 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -19,6 +19,8 @@ p{{loop.index}}

p{{loop.index}}.Pass()

{%- elif param.kind|is_interface_kind -%}

mojo::MakeProxy<{{param.kind.name}}>(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}})))

+{%- elif param.kind|is_interface_request_kind -%}

+mojo::MakeRequest<{{param.kind.kind.name}}>(mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}})))

{%- elif param.kind|is_handle_kind -%}

mojo::MakeScopedHandle(mojo::internal::FetchAndReset(&params->{{param.name}}))

{%- elif param.kind|is_enum_kind -%}

@@ -53,9 +55,11 @@ params->{{param.name}}

params->{{param.name}} = mojo::MessagePipeHandle();

} else {

// Delegate handle.

- params->{{param.name}} =

- in_{{param.name}}.ResetAndReturnMessagePipe().release();

+ params->{{param.name}} = in_{{param.name}}.PassMessagePipe().release();

}

+{%- elif param.kind|is_interface_request_kind %}

+ // Delegate handle.

+ params->{{param.name}} = in_{{param.name}}.PassMessagePipe().release();

{%- elif param.kind|is_handle_kind %}

params->{{param.name}} = in_{{param.name}}.release();

{%- else %}