Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2723213002: DWARF and unwind support for AOT assembly output. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/datastream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 78363deb6d8eeb9af1cd0c811663678161b8f56e..754fe080db522e86e1425313a9a4dafceec80e1c 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -6686,6 +6686,7 @@ Dart_CreateAppAOTSnapshotAsAssembly(uint8_t** assembly_buffer,
&image_writer, &image_writer);
writer.WriteFullSnapshot();
+ image_writer.Finalize();
*assembly_size = image_writer.AssemblySize();
return Api::Success();
@@ -6710,6 +6711,11 @@ Dart_CreateAppAOTSnapshotAsBlobs(uint8_t** vm_snapshot_data_buffer,
return Api::NewError(
"This VM was built without support for AOT compilation.");
#else
+ if (FLAG_dwarf_stack_traces) {
+ return Api::NewError(
+ "--dwarf_stack_traces requires creating an AOT snapshot as assembly.");
+ }
+
API_TIMELINE_DURATION;
DARTSCOPE(Thread::Current());
Isolate* I = T->isolate();
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/datastream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698