Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: runtime/vm/clustered_snapshot.cc

Issue 2723213002: DWARF and unwind support for AOT assembly output. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/clustered_snapshot.cc
diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc
index 3bd1c6ce9d3db287e5abbea9015a6f77f32c8da4..6b28d7d4cf064b1e159c136f7eac18d2cafa1fff 100644
--- a/runtime/vm/clustered_snapshot.cc
+++ b/runtime/vm/clustered_snapshot.cc
@@ -1567,8 +1567,10 @@ class CodeSerializationCluster : public SerializationCluster {
s->Push(code->ptr()->exception_handlers_);
s->Push(code->ptr()->pc_descriptors_);
s->Push(code->ptr()->stackmaps_);
- s->Push(code->ptr()->inlined_id_to_function_);
- s->Push(code->ptr()->code_source_map_);
+ if (!FLAG_dwarf_stack_traces) {
+ s->Push(code->ptr()->inlined_id_to_function_);
+ s->Push(code->ptr()->code_source_map_);
+ }
if (s->kind() == Snapshot::kAppJIT) {
s->Push(code->ptr()->deopt_info_array_);
@@ -1621,8 +1623,13 @@ class CodeSerializationCluster : public SerializationCluster {
s->WriteRef(code->ptr()->exception_handlers_);
s->WriteRef(code->ptr()->pc_descriptors_);
s->WriteRef(code->ptr()->stackmaps_);
- s->WriteRef(code->ptr()->inlined_id_to_function_);
- s->WriteRef(code->ptr()->code_source_map_);
+ if (FLAG_dwarf_stack_traces) {
+ s->WriteRef(Array::null());
+ s->WriteRef(CodeSourceMap::null());
+ } else {
+ s->WriteRef(code->ptr()->inlined_id_to_function_);
+ s->WriteRef(code->ptr()->code_source_map_);
+ }
if (s->kind() == Snapshot::kAppJIT) {
s->WriteRef(code->ptr()->deopt_info_array_);
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/dart.cc » ('j') | runtime/vm/dwarf.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698