Apply transformers and other work arounds to get boostrapping to work.

Apply transformers and other work arounds to get boostrapping to work.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/628be2b36a760291c4cbfc57e5801bd47dca5f0f

[ahe, 2017-03-01 17:35:21]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-03-02 06:05:08]

LGTM

https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
File pkg/front_end/test/fasta/bootstrap_test.dart (right):

https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
pkg/front_end/test/fasta/bootstrap_test.dart:40: try {
Consider adding a flag to 'compare' which controls whether or not to throw on
different or equal input instead of catching the exception and comparing the
text.

[ahe, 2017-03-02 12:06:23]

Thank you, Karl!

https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
File pkg/front_end/test/fasta/bootstrap_test.dart (right):

https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
pkg/front_end/test/fasta/bootstrap_test.dart:40: try {
On 2017/03/02 06:05:08, karlklose wrote:
> Consider adding a flag to 'compare' which controls whether or not to throw on
> different or equal input instead of catching the exception and comparing the
> text.

I want to test that it throws, so I don't think a flag would be good. An
alternative I considered was adding an exception class for this purpose. But
that seemed a bit too much for a single test. WDYT?

[karlklose, 2017-03-02 13:19:40]

On 2017/03/02 12:06:23, ahe wrote:
> Thank you, Karl!
> 
>
https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
> File pkg/front_end/test/fasta/bootstrap_test.dart (right):
> 
>
https://codereview.chromium.org/2723173002/diff/1/pkg/front_end/test/fasta/bo...
> pkg/front_end/test/fasta/bootstrap_test.dart:40: try {
> On 2017/03/02 06:05:08, karlklose wrote:
> > Consider adding a flag to 'compare' which controls whether or not to throw
on
> > different or equal input instead of catching the exception and comparing the
> > text.
> 
> I want to test that it throws, so I don't think a flag would be good. An
> alternative I considered was adding an exception class for this purpose. But
> that seemed a bit too much for a single test. WDYT?

I would prefer to add an exception class.

[ahe, 2017-03-02 13:27:40]

On 2017/03/02 13:19:40, karlklose wrote:
> I would prefer to add an exception class.

Done.

[ahe, 2017-03-02 13:32:04]

Description was changed from

==========
Apply transformers and other work arounds to get boostrapping to work.
==========

to

==========
Apply transformers and other work arounds to get boostrapping to work.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/628be2b36a760291c4cbfc57e5801bd47dca5f0f
==========

[ahe, 2017-03-02 13:32:06]

Committed patchset #4 (id:60001) manually as
628be2b36a760291c4cbfc57e5801bd47dca5f0f (presubmit successful).