Add unittests of ArcCustomNotificationView

components/exo/notification_surface.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_EXO_NOTIFICATION_SURFACE_H_
 #define COMPONENTS_EXO_NOTIFICATION_SURFACE_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "components/exo/surface_delegate.h"

[hidehiko, 2017/03/02 15:38:16]

Unused?

 #include "components/exo/surface_observer.h"

[hidehiko, 2017/03/02 15:38:15]

Ditto.

 #include "ui/gfx/geometry/size.h"
 
 namespace aura {
 class Window;
 }
 
+namespace views {
+class NativeViewHost;
+}
+
 namespace exo {
-class NotificationSurfaceManager;
-class Surface;
 
 // Handles notification surface role of a given surface.
-class NotificationSurface : public SurfaceDelegate, public SurfaceObserver {
+class NotificationSurface {
  public:
-  NotificationSurface(NotificationSurfaceManager* manager,
-                      Surface* surface,
-                      const std::string& notification_id);
-  ~NotificationSurface() override;
+  virtual ~NotificationSurface() {}

[hidehiko, 2017/03/02 15:38:16]

How about; s/{}/= default;/

 
-  gfx::Size GetSize() const;
+  virtual gfx::Size GetSize() const = 0;

[hidehiko, 2017/03/02 15:38:15]

Because this is now interface, could you document for each function?

 
-  aura::Window* window() { return window_.get(); }
-  const std::string& notification_id() const { return notification_id_; }
+  virtual void AttachWindow(views::NativeViewHost* nvh) = 0;
 
-  // Overridden from SurfaceDelegate:
-  void OnSurfaceCommit() override;
-  bool IsSurfaceSynchronized() const override;
-
-  // Overridden from SurfaceObserver:
-  void OnSurfaceDestroying(Surface* surface) override;
-
- private:
-  NotificationSurfaceManager* const manager_;  // Not owned.
-  Surface* surface_;                           // Not owned.
-  const std::string notification_id_;
-
-  std::unique_ptr<aura::Window> window_;
-  bool added_to_manager_ = false;
-
-  DISALLOW_COPY_AND_ASSIGN(NotificationSurface);
+  virtual aura::Window* window() = 0;

[hidehiko, 2017/03/02 15:38:16]

Optional: These are now virtual function so it can be non-trivial getter. So,
how about GetWindow() and GetNotificationId() ?

+  virtual const std::string& notification_id() const = 0;
 };
 
 }  // namespace exo
 
 #endif  // COMPONENTS_EXO_NOTIFICATION_SURFACE_H_