Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.h

Issue 2723133004: Get rid of redundant member variable SelectionEditor::m_logicalRange (Closed)
Patch Set: 2017-03-06T13:02:21 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionEditor.h
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.h b/third_party/WebKit/Source/core/editing/SelectionEditor.h
index e853cfed5c37a1737d194e6513a4f60c59771b69..322b3b4e2ebe3b98f0f8dfaf4dc4c399595cbd40 100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.h
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.h
@@ -67,9 +67,6 @@ class SelectionEditor final : public GarbageCollectedFinalized<SelectionEditor>,
Range* firstRange() const;
// There functions are exposed for |FrameSelection|.
- void resetLogicalRange();
- void setLogicalRange(Range*);
-
void cacheRangeOfDocument(Range*);
Range* documentCachedRange() const;
void clearDocumentCachedRange();
@@ -112,13 +109,6 @@ class SelectionEditor final : public GarbageCollectedFinalized<SelectionEditor>,
SelectionInDOMTree m_selection;
- // TODO(editing-dev): Removing |m_logicalRange|
- // The range specified by the user, which may not be visually canonicalized
- // (hence "logical"). This will be invalidated if the underlying
- // |VisibleSelection| changes. If that happens, this variable will
- // become |nullptr|, in which case logical positions == visible positions.
- Member<Range> m_logicalRange;
-
// If document is root, document.getSelection().addRange(range) is cached on
// this.
Member<Range> m_cachedRange;

Powered by Google App Engine
This is Rietveld 408576698