Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2723133004: Get rid of redundant member variable SelectionEditor::m_logicalRange (Closed)
Patch Set: 2017-03-06T13:02:21 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 9247096b66c092cb4808ae1119c89ba1335a6e66..3a9f89299f25fca2abc03526488c89ae29662a54 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -687,11 +687,6 @@ bool FrameSelection::setSelectedRange(const EphemeralRange& range,
SetSelectionOptions options) {
if (range.isNull())
return false;
- m_selectionEditor->resetLogicalRange();
- // Since |FrameSeleciton::setSelection()| dispatches events and DOM tree
- // can be modified by event handlers, we should create |Range| object before
- // calling it.
- Range* logicalRange = createRange(range);
setSelection(SelectionInDOMTree::Builder()
.setBaseAndExtent(range)
.setAffinity(affinity)
@@ -699,7 +694,6 @@ bool FrameSelection::setSelectedRange(const EphemeralRange& range,
SelectionDirectionalMode::Directional)
.build(),
options);
- m_selectionEditor->setLogicalRange(logicalRange);
return true;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698