Get rid of redundant member variable SelectionEditor::m_logicalRange

third_party/WebKit/Source/core/editing/SelectionEditor.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 43 matching lines @@
   m_selection = SelectionInDOMTree();
   m_cachedVisibleSelectionInDOMTree = VisibleSelection();
   m_cachedVisibleSelectionInFlatTree = VisibleSelectionInFlatTree();
   m_cacheIsDirty = false;
   if (!shouldAlwaysUseDirectionalSelection())
     return;
   m_selection.m_isDirectional = true;
 }
 
 void SelectionEditor::dispose() {
-  resetLogicalRange();
   clearDocumentCachedRange();
   clearVisibleSelection();
 }
 
 Document& SelectionEditor::document() const {
   DCHECK(lifecycleContext());
   return *lifecycleContext();
 }
 
 const VisibleSelection& SelectionEditor::computeVisibleSelectionInDOMTree()
@@ skipping 40 matching lines @@
     return;
   m_cachedVisibleSelectionInFlatTree = VisibleSelectionInFlatTree();
   m_cachedVisibleSelectionInDOMTree = VisibleSelection();
   m_cacheIsDirty = true;
 }
 
 void SelectionEditor::setSelection(const SelectionInDOMTree& newSelection) {
   newSelection.assertValidFor(document());
   if (m_selection == newSelection)
     return;
-  resetLogicalRange();
   clearDocumentCachedRange();
   markCacheDirty();
   m_selection = newSelection;
 }
 
 void SelectionEditor::didChangeChildren(const ContainerNode&) {
   markCacheDirty();
   didFinishDOMMutation();
 }
 
@@ skipping 207 matching lines @@
     didFinishDOMMutation();
     return;
   }
   const Position& newBase =
       updatePostionAfterAdoptingTextNodeSplit(m_selection.m_base, oldNode);
   const Position& newExtent =
       updatePostionAfterAdoptingTextNodeSplit(m_selection.m_extent, oldNode);
   didFinishTextChange(newBase, newExtent);
 }
 
-void SelectionEditor::resetLogicalRange() {
-  // Non-collapsed ranges are not allowed to start at the end of a line that
-  // is wrapped, they start at the beginning of the next line instead
-  if (!m_logicalRange)
-    return;
-  m_logicalRange->dispose();
-  m_logicalRange = nullptr;
-}
-
-void SelectionEditor::setLogicalRange(Range* range) {
-  DCHECK_EQ(range->ownerDocument(), document());
-  DCHECK(!m_logicalRange) << "A logical range should be one.";
-  m_logicalRange = range;
-}
-
 Range* SelectionEditor::firstRange() const {
-  if (m_logicalRange)
-    return m_logicalRange->cloneRange();
   return createRange(firstEphemeralRangeOf(computeVisibleSelectionInDOMTree()));
 }
 
 bool SelectionEditor::shouldAlwaysUseDirectionalSelection() const {
   return frame()->editor().behavior().shouldConsiderSelectionAsDirectional();
 }
 
 bool SelectionEditor::needsUpdateVisibleSelection() const {
   return m_cacheIsDirty || m_styleVersion != document().styleVersion();
 }
@@ skipping 32 matching lines @@
 
 void SelectionEditor::clearDocumentCachedRange() {
   m_cachedRange = nullptr;
 }
 
 DEFINE_TRACE(SelectionEditor) {
   visitor->trace(m_frame);
   visitor->trace(m_selection);
   visitor->trace(m_cachedVisibleSelectionInDOMTree);
   visitor->trace(m_cachedVisibleSelectionInFlatTree);
-  visitor->trace(m_logicalRange);
   visitor->trace(m_cachedRange);
   SynchronousMutationObserver::trace(visitor);
 }
 
 }  // namespace blink