Issue 2723123002: Change a C++ type to avoid triggering an ASSERT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2723123002: Change a C++ type to avoid triggering an ASSERT. (Closed)

Created:
3 years, 9 months ago by Kevin Millikin (Google)

Modified:
3 years, 9 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Change a C++ type to avoid triggering an ASSERT. Malloc'd memory is uninitialized so C++ constructors are not run. For class Ref, operator= asserts (basically) that the constructor has been run. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/d921f94367a47ef51cbcbeb31e18bfef91bc2b2d

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/kernel_binary.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

3 years, 9 months ago (2017-03-01 15:50:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d921f94367a47ef51cbcbeb31e18bfef91bc2b2d (presubmit successful).