Consolidate analyzer dependencies.

Consolidate analyzer dependencies.

This allows us to create a smaller .dill file for Fasta.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/6176847e36f85fa4fec6c7394ae356c6cef9a89d

[ahe, 2017-03-01 16:03:19]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-01 16:06:59]

ahe@google.com changed reviewers:
+ karlklose@google.com, paulberry@google.com

[ahe, 2017-03-01 16:07:00]

I only need a review from one of you.

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/test/subp...
File pkg/front_end/test/subpackage_relationships_test.dart (right):

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/test/subp...
pkg/front_end/test/subpackage_relationships_test.dart:104:
'lib/src/fasta/analyzer',
I'll try getting rid of this at a later time.

[ahe, 2017-03-01 16:27:06]

Before: 4.8M
After: 1.7M

That's a reduction by 65% :-D

[Paul Berry, 2017-03-01 21:56:31]

lgtm

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart (right):

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart:56: main(List<String>
arguments) async {
As I mentioned in https://codereview.chromium.org/2726793003/, I believe main()
functions should all be outside of "lib/".  See that CL for details.

[ahe, 2017-03-02 11:41:50]

Thank you, Paul!

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart (right):

https://codereview.chromium.org/2723113002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart:56: main(List<String>
arguments) async {
On 2017/03/01 21:56:31, Paul Berry wrote:
> As I mentioned in https://codereview.chromium.org/2726793003/, I believe
main()
> functions should all be outside of "lib/".  See that CL for details.

Yes. I've done that in CL 2722223006.

[ahe, 2017-03-02 11:59:54]

Description was changed from

==========
Consolidate analyzer dependencies.

This allows us to create a smaller .dill file for Fasta.
==========

to

==========
Consolidate analyzer dependencies.

This allows us to create a smaller .dill file for Fasta.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6176847e36f85fa4fec6c7394ae356c6cef9a89d
==========

[ahe, 2017-03-02 11:59:55]

Committed patchset #2 (id:40001) manually as
6176847e36f85fa4fec6c7394ae356c6cef9a89d (presubmit successful).