Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl

Issue 2723093004: Adds SVGImageElement as a CanvasImageSource (Closed)
Patch Set: Refactored, added tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
index c599cbcd420dd7a089d214fcb6f0779c207c2079..2f37d674fa525e6738bdae13bcbdcc2130f2cefc 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
@@ -25,8 +25,16 @@
// http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#canvasrenderingcontext2d
+// The spec specifies:
+// typedef (HTMLImageElement or
+// SVGImageElement) HTMLOrSVGImageElement;
+// but there's a problem with our IDL code generator for typedef-in-typedef,
fs 2017/03/13 13:56:34 I saw crbug.com/700225, and that some fixes had la
fserb 2017/03/21 19:15:22 Arghh, that took me a while to figure out. So, the
fs 2017/03/21 21:05:41 Roger that.
+// so we split this into two for simplicity. There's no difference from a user
+// perspective.
+
typedef (CSSImageValue or
HTMLImageElement or
+ SVGImageElement or
HTMLVideoElement or
HTMLCanvasElement or
ImageBitmap or

Powered by Google App Engine
This is Rietveld 408576698