third_party/WebKit/LayoutTests/http/tests/security/canvas-remote-read-remote-svg-image.html - Issue 2723093004: Adds SVGImageElement as a CanvasImageSource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/canvas-remote-read-remote-svg-image.html

Issue 2723093004: Adds SVGImageElement as a CanvasImageSource (Closed)

Patch Set: Refactored Canvas code out Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg-expected.html ('k') | third_party/WebKit/Source/bindings/modules/v8/generated.gni » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasHTMLSVGImage.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="/resources/testharness.js"></script>

	3 <script src="/resources/testharnessreport.js"></script>

	4 <body></body>

	5 <script>

	6 var stTest = async_test("Checks no cross-origin on tainted canvas due to SVG ima ge");

	7

	8 stTest.step(function() {
	Justin Novosad 2017/03/06 21:37:32 The code below does not need to be inside a 'step' The code below does not need to be inside a 'step' call. Only the event listener needs it. fs 2017/03/06 22:46:15 I believe there's a positive side to using a step Show quoted text On 2017/03/06 at 21:37:32, Justin Novosad wrote: > The code below does not need to be inside a 'step' call. Only the event listener needs it. I believe there's a positive side to using a step though - if something here throws the test will fail (rather than time out.) IIRC. This could be written as: async_test(function(t) { ...stuff... image.addEventListener('load', t.step_func_done(...)); ...more stuff... }, 'Description...'); for slightly less harness mongering. fserb 2017/03/07 20:44:02 done. Show quoted text On 2017/03/06 at 22:46:15, fs wrote: > On 2017/03/06 at 21:37:32, Justin Novosad wrote: > > The code below does not need to be inside a 'step' call. Only the event listener needs it. > > I believe there's a positive side to using a step though - if something here throws the test will fail (rather than time out.) IIRC. > > This could be written as: > > async_test(function(t) { > ...stuff... > image.addEventListener('load', t.step_func_done(...)); > ...more stuff... > }, 'Description...'); > > for slightly less harness mongering. done.
	9 var canvas = document.createElement("canvas");

	10 canvas.width = canvas.height = 100;

	11

	12 var svg = document.createElementNS('http://www.w3.org/2000/svg','svg');

	13 var image = document.createElementNS("http://www.w3.org/2000/svg", "image");

	14 svg.appendChild(image);

	15 image.setAttributeNS('http://www.w3.org/1999/xlink','href',

	16 'http://localhost:8000/security/resources/red200x100.png');

	17

	18 var ctx = canvas.getContext("2d");

	19

	20 image.addEventListener('load', stTest.step_func(function() {
	fs 2017/03/06 22:46:15 Could use step_func_done (and remove the explicit Could use step_func_done (and remove the explicit .done()) fserb 2017/03/07 20:44:02 done. Show quoted text On 2017/03/06 at 22:46:15, fs wrote: > Could use step_func_done (and remove the explicit .done()) done.
	21 ctx.drawImage(image, 0, 0);

	22

	23 assert_throws("SecurityError", function() {

	24 var c = ctx.getImageData(0, 0, 1, 1);

	25 }, "We are trying cross-origin getImageData");

	26 stTest.done();

	27 }));

	28

	29 document.body.appendChild(canvas);

	30 document.body.appendChild(svg);

	31 });

	32

	33 </script>

OLD	NEW