third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg-expected.html - Issue 2723093004: Adds SVGImageElement as a CanvasImageSource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg-expected.html

Issue 2723093004: Adds SVGImageElement as a CanvasImageSource (Closed)

Patch Set: Refactored, added tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-svg.html ('k') | third_party/WebKit/LayoutTests/fast/canvas/resources/circle.svg » ('j') | third_party/WebKit/LayoutTests/fast/canvas/resources/circle.svg » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 svg {

	4 border: 1px solid black;

	5 }

	6 #img4 {

	7 display: none;

	8 }

	9 </style>

	10 <svg id="s1" width="20px" height="20px">

	11 <image id="img1" href="resources/pattern.png" x="0" y="0" width="20px" height= "20px" />

	12 </svg>

	13 <svg id="s2" width="20px" height="20px">

	14 <image id="img1" href="resources/pattern.png" x="10" y="10" width="20px" heigh t="20px" />

	15 </svg>

	16 <svg id="s3" width="20px" height="20px">

	17 <image id="img3" href="resources/pattern.png" x="0" y="0" width="20px" height= "20px" />

	18 </svg>

	19 <svg id="s4" width="20px" height="20px">

	20 <image id="img4" href="invalid" x="0" y="0" width="20px" height="20px" />

	21 </svg>

	22 <svg id="s5" width="20px" height="20px">

	23 </svg>

	24 <svg id="s6" width="20px" height="20px">

	25 <circle cx="50%" cy="50%" r="50%" style="fill:blue;" />
	Justin Novosad 2017/03/13 14:22:26 This one shows a minor discrepancy in the pixel re This one shows a minor discrepancy in the pixel results. Perhaps it would go away if you just referenced circle.svg. If not, maybe you can remove this specific case from the test. It is possible that the anti-aliasing is too numerically sensitive for this case to be used in a ref test. fserb 2017/03/21 19:15:22 I didn't see that. But yeah, referencing circle.sv Show quoted text On 2017/03/13 at 14:22:26, Justin Novosad wrote: > This one shows a minor discrepancy in the pixel results. Perhaps it would go away if you just referenced circle.svg. If not, maybe you can remove this specific case from the test. It is possible that the anti-aliasing is too numerically sensitive for this case to be used in a ref test. I didn't see that. But yeah, referencing circle.svg makes sense, I guess? At least we guarantee that we have the same problem as a regular svg image element. ;)
	26 </svg>

	27 <svg id="s7" width="20px" height="20px">

	28 </svg>

	29 <svg id="s8" width="20px" height="20px">

	30 </svg>

OLD	NEW