net/disk_cache/blockfile/block_files.cc - Issue 2723083004: Remove a scoped_refptr<>::swap overload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/block_files.cc

Issue 2723083004: Remove a scoped_refptr<>::swap overload (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/block_files.cc

diff --git a/net/disk_cache/blockfile/block_files.cc b/net/disk_cache/blockfile/block_files.cc

index 10798dae2bfe97beed1ed812b60364b5565f1410..b2664801daf7fe00d4064804abcd43e0b27d9977 100644

--- a/net/disk_cache/blockfile/block_files.cc

+++ b/net/disk_cache/blockfile/block_files.cc

@@ -515,7 +515,8 @@ bool BlockFiles::OpenBlockFile(int index) {

ScopedFlush flush(file.get());

DCHECK(!block_files_[index]);

- file.swap(&block_files_[index]);

+ block_files_[index] = file.get();

+ file->AddRef();

return true;

}