Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: chrome/browser/chromeos/libc_close_tracking.cc

Issue 2723063002: ChromeOS: Do not use TraceStackFramePointers() with MSAN. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/libc_close_tracking.cc
diff --git a/chrome/browser/chromeos/libc_close_tracking.cc b/chrome/browser/chromeos/libc_close_tracking.cc
index 5f77f0df827cf26037202b63997952eb9ad85c90..260a116b5a2e664ed3e7064d42af3ccc765f6882 100644
--- a/chrome/browser/chromeos/libc_close_tracking.cc
+++ b/chrome/browser/chromeos/libc_close_tracking.cc
@@ -119,9 +119,11 @@ int CloseOverride(int fd) {
// Capture stack for successful close.
if (ret == 0) {
-#if HAVE_TRACE_STACK_FRAME_POINTERS
+#if HAVE_TRACE_STACK_FRAME_POINTERS && !defined(MEMORY_SANITIZER)
// Use TraceStackFramePointers because the backtrack() based default
// capturing gets only the last stack frame and is not useful.
+ // With the exception of when MSAN is enabled. See comments for why
+ // StackTraceTest.TraceStackFramePointers is disabled in MSAN builds.
const void* frames[64];
const size_t frame_count =
base::debug::TraceStackFramePointers(frames, arraysize(frames), 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698