Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/wtf/text/AtomicString.h

Issue 2723053002: Use the correct case converter for |localName| and |tagName| (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/AtomicString.h
diff --git a/third_party/WebKit/Source/wtf/text/AtomicString.h b/third_party/WebKit/Source/wtf/text/AtomicString.h
index 4f4a96bbe874cb23472c505131d724067c1598da..e6d7f39affc548f222985a383335780e34e69a55 100644
--- a/third_party/WebKit/Source/wtf/text/AtomicString.h
+++ b/third_party/WebKit/Source/wtf/text/AtomicString.h
@@ -168,9 +168,10 @@ class WTF_EXPORT AtomicString {
AtomicString lower() const;
AtomicString upper() const { return AtomicString(impl()->upper()); }
- // Returns a lowercase version of the string. This function converts only
- // upper-case ASCII characters.
+ // Returns a lowercase/uppercase version of the string. This function converts
+ // only upper/lower-case ASCII characters.
AtomicString lowerASCII() const;
+ AtomicString upperASCII() const { return AtomicString(impl()->upperASCII()); }
Sunny 2017/03/01 08:59:25 Hi tkent, I'm not sure call impl() here will retur
tkent 2017/03/01 12:21:27 It should support null impl(). So implement it lik
int toInt(bool* ok = 0) const { return m_string.toInt(ok); }
double toDouble(bool* ok = 0) const { return m_string.toDouble(ok); }

Powered by Google App Engine
This is Rietveld 408576698