Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 2723033002: Skip nullptr after copyToVector() from HeapHashSet<WeakMember> (Closed)
Patch Set: Added comments (haraken's nit) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/FontCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
index a5970731553f047a430e143a04a386c9331c6220..48bc761b5477f9c65b50c18b90db82a814de017e 100644
--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
@@ -73,8 +73,12 @@ void CSSFontSelector::dispatchInvalidationCallbacks() {
HeapVector<Member<CSSFontSelectorClient>> clients;
copyToVector(m_clients, clients);
- for (auto& client : clients)
- client->fontsNeedUpdate(this);
+ for (auto& client : clients) {
+ // This should not be nullptr, but to see if checking nullptr can suppress
+ // crashes. crbug.com/581698
+ if (client)
+ client->fontsNeedUpdate(this);
+ }
}
void CSSFontSelector::fontFaceInvalidated() {
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/FontCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698