Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2723003002: Editing: Fix caret blinking after a typing. (Closed)
Patch Set: Apply review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.h
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.h b/third_party/WebKit/Source/core/editing/FrameCaret.h
index 3850e5520b6d94b9d19febe8331397af8f964602..50639c1d25936bd758c12e8062844441e7d27a13 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.h
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.h
@@ -88,6 +88,7 @@ class CORE_EXPORT FrameCaret final
const DisplayItemClient& caretDisplayItemClientForTesting() const;
const LayoutBlock* caretLayoutBlockForTesting() const;
bool shouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
+ void recreateCaretBlinkTimerForTesting(RefPtr<WebTaskRunner>);
DECLARE_TRACE();
@@ -106,7 +107,7 @@ class CORE_EXPORT FrameCaret final
const std::unique_ptr<CaretDisplayItemClient> m_displayItemClient;
CaretVisibility m_caretVisibility;
// TODO(https://crbug.com/668758): Consider using BeginFrame update for this.
- TaskRunnerTimer<FrameCaret> m_caretBlinkTimer;
+ std::unique_ptr<TaskRunnerTimer<FrameCaret>> m_caretBlinkTimer;
bool m_shouldPaintCaret : 1;
bool m_isCaretBlinkingSuspended : 1;
bool m_shouldShowBlockCursor : 1;
« no previous file with comments | « third_party/WebKit/Source/core/editing/BUILD.gn ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698