Issue 27230002: Runtime configuration setting for suppressing JPEG decoder errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27230002: Runtime configuration setting for suppressing JPEG decoder errors. (Closed)

Created:
7 years, 2 months ago by hal.canary

Modified:
7 years, 2 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Runtime configuration setting for suppressing JPEG decoder errors. Add new runtime config variable, images.jpeg.suppressDecoderErrors which defaults to false in Debug and true otherwise. When Jpeg errors are suppressed and an error happens, SkJPEGImageDecoder::onDecode() will return silently false (Consequently, so will SkImageDecoder's DecodeFile() and DecodeMemory() functions). Also, the test_image_decoder program now respects runtime configuration settings. BUG=skia:1680 R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11763

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
	M	src/images/SkImageDecoder_libjpeg.cpp	View		4 chunks	+23 lines, -6 lines	0 comments	Download
	M	tools/test_image_decoder.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hal.canary

7 years, 2 months ago (2013-10-14 20:08:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r11763 (presubmit successful).

Expand Messages | Collapse Messages