Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10250)

Unified Diff: chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js

Issue 272293002: Expand the IME test framework to test the Compact layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
diff --git a/chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js b/chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
index 79cd975c070d0dc8fe86d2eb28ef7faed400af5a..656bcc5275ca39471bda50e6c0a33bd68b0b74e7 100644
--- a/chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
+++ b/chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
@@ -7,7 +7,7 @@
function testShiftHighlight() {
// Start in lower case.
mockTouchType('l');
- var shift = getShiftKey(Alignment.LEFT);
+ var shift = getKey("leftShift");
generateTouchEvent(shift, 'touchstart', true, true);
generateTouchEvent(shift, 'touchend', true, true);
// Transitioned to upper case.
@@ -19,11 +19,17 @@ function testShiftHighlight() {
}
function testCapslock() {
+ // Skip this test for compact layouts since they don't have capslock keys.
+ var id = getLayoutId();
+ if (id.indexOf("compact") > 0)
+ return;
+ console.error(id);
bshe 2014/05/12 13:24:27 nit: remove this console error.
rsadam 2014/05/12 20:23:46 Done.
+
// Start in lower case.
mockTouchType('l');
// To upper case.
// TODO(rsadam@): Only test this for the full layout.
- var caps = document.querySelector('#' + CAPSLOCK_ID);
+ var caps = getKey("capslock")
generateTouchEvent(caps, 'touchstart', true, true);
generateTouchEvent(caps, 'touchend', true, true);
mockTouchType('A');

Powered by Google App Engine
This is Rietveld 408576698