Expand the IME test framework to test the Compact layout.

We currently have tests only for the full IME layout. Expand the IME test framework to test the Compact layout as well.

BUG=372539
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269957

[rsadam, 2014-05-09 22:46:42]

PTAL!

[bshe, 2014-05-12 13:24:27]

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
File
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
(right):

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:26:
console.error(id);
nit: remove this console error.

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right):

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:64: var
KEY_IDS = {
Could you document why only these characters have ID here. And where are these
IDs come from. It would easier for others to understand.

[rsadam, 2014-05-12 20:23:46]

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
File
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
(right):

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:26:
console.error(id);
On 2014/05/12 13:24:27, bshe wrote:
> nit: remove this console error.

Done.

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right):

https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:64: var
KEY_IDS = {
On 2014/05/12 13:24:27, bshe wrote:
> Could you document why only these characters have ID here. And where are these
> IDs come from. It would easier for others to understand.

Done.

[bshe, 2014-05-12 20:38:15]

On 2014/05/12 20:23:46, rsadam wrote:
>
https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
> File
> chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
> (right):
> 
>
https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
>
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:26:
> console.error(id);
> On 2014/05/12 13:24:27, bshe wrote:
> > nit: remove this console error.
> 
> Done.
> 
>
https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
> File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js
(right):
> 
>
https://codereview.chromium.org/272293002/diff/1/chrome/test/data/chromeos/vi...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:64: var
> KEY_IDS = {
> On 2014/05/12 13:24:27, bshe wrote:
> > Could you document why only these characters have ID here. And where are
these
> > IDs come from. It would easier for others to understand.
> 
> Done.

lgtm

[rsadam, 2014-05-12 20:44:55]

+miket for OWNERS

[miket_OOO, 2014-05-12 20:58:35]

On 2014/05/12 20:44:55, rsadam wrote:
> +miket for OWNERS

chrome/browser/chromeos/extensions/input_view_browsertest.cc OWNERS LGTM

[rsadam, 2014-05-12 20:58:57]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2014-05-12 20:59:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsadam@chromium.org/272293002/20001

[commit-bot: I haz the power, 2014-05-13 01:32:54]

Change committed as 269957