Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 27229004: Guard colorNames variable under SK_SUPPORT_UNITTEST. (Closed)

Created:
7 years, 2 months ago by tfarina
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Guard colorNames variable under SK_SUPPORT_UNITTEST. That way clang does not complain with unneeded-internal-declaration warning, because otherwise to clang this variable is unused and thus it won't emit code for it. The warning is: ../../src/utils/SkParseColor.cpp:35:3: error: variable 'colorNames' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] } colorNames[] = { R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/utils/SkParseColor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years, 2 months ago (2013-10-14 23:08:14 UTC) #1
tfarina
ping??
7 years, 2 months ago (2013-10-15 22:11:07 UTC) #2
bsalomon
lgtm
7 years, 2 months ago (2013-10-15 22:52:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/27229004/1
7 years, 2 months ago (2013-10-15 22:52:14 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 23:01:10 UTC) #5
Message was sent while issue was closed.
Change committed as 11798

Powered by Google App Engine
This is Rietveld 408576698