Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: gpu/command_buffer/tests/gl_fence_sync_unittest.cc

Issue 2722883002: gpu: Allow waiting on sync tokens without sync token client. (Closed)
Patch Set: review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/tests/fuzzer_main.cc ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/tests/gl_fence_sync_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_fence_sync_unittest.cc b/gpu/command_buffer/tests/gl_fence_sync_unittest.cc
index 65ff1b188cfd2a84476eddcdad9178179132a1d1..a9b68d32fb24e8b7b2087b214f79e058e23bbe18 100644
--- a/gpu/command_buffer/tests/gl_fence_sync_unittest.cc
+++ b/gpu/command_buffer/tests/gl_fence_sync_unittest.cc
@@ -23,7 +23,7 @@ namespace gpu {
class GLFenceSyncTest : public testing::Test {
protected:
void SetUp() override {
- sync_point_manager_.reset(new SyncPointManager(false));
+ sync_point_manager_.reset(new SyncPointManager());
GLManager::Options options;
options.sync_point_manager = sync_point_manager_.get();
@@ -53,20 +53,11 @@ TEST_F(GLFenceSyncTest, SimpleReleaseWait) {
ASSERT_TRUE(GL_NO_ERROR == glGetError());
// Make sure it is actually released.
- scoped_refptr<SyncPointClientState> gl1_client_state =
- sync_point_manager_->GetSyncPointClientState(gl1_.GetNamespaceID(),
- gl1_.GetCommandBufferID());
- EXPECT_TRUE(gl1_client_state->IsFenceSyncReleased(fence_sync));
+ EXPECT_TRUE(sync_point_manager_->IsSyncTokenReleased(sync_token));
gl2_.MakeCurrent();
glWaitSyncTokenCHROMIUM(sync_token.GetConstData());
glFinish();
-
- // gl2 should not have released anything.
- scoped_refptr<SyncPointClientState> gl2_client_state =
- sync_point_manager_->GetSyncPointClientState(gl2_.GetNamespaceID(),
- gl2_.GetCommandBufferID());
- EXPECT_EQ(0u, gl2_client_state->fence_sync_release());
}
static void TestCallback(int* storage, int assign) {
« no previous file with comments | « gpu/command_buffer/tests/fuzzer_main.cc ('k') | gpu/command_buffer/tests/gl_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698