Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart

Issue 2722753002: Remove HRuntimeType implementation (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart
diff --git a/pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart b/pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart
index ab44766eea8b877bb925bed00bd66f5f0e6e846d..be9011f1505f2abec9909245b00cf3df15fa9448 100644
--- a/pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart
+++ b/pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart
@@ -89,6 +89,19 @@ class TypeVariableCheckedModeHelper extends CheckedModeHelper {
}
}
+class FunctionTypeRepresentationCheckedModeHelper extends CheckedModeHelper {
+ const FunctionTypeRepresentationCheckedModeHelper(String name) : super(name);
+
+ CallStructure get callStructure => CallStructure.TWO_ARGS;
+
+ void generateAdditionalArguments(SsaCodeGenerator codegen,
+ HTypeConversion node, List<jsAst.Expression> arguments) {
+ assert(node.typeExpression.isFunctionType);
+ codegen.use(node.typeRepresentation);
+ arguments.add(codegen.pop());
+ }
+}
+
class SubtypeCheckedModeHelper extends CheckedModeHelper {
const SubtypeCheckedModeHelper(String name) : super(name);
@@ -96,6 +109,8 @@ class SubtypeCheckedModeHelper extends CheckedModeHelper {
void generateAdditionalArguments(SsaCodeGenerator codegen,
HTypeConversion node, List<jsAst.Expression> arguments) {
+ // TODO(sra): Move these calls into the SSA graph so that the arguments can
+ // be optimized, e,g, GVNed.
InterfaceType type = node.typeExpression;
ClassEntity element = type.element;
jsAst.Name isField = codegen.backend.namer.operatorIs(element);
@@ -149,6 +164,8 @@ class CheckedModeHelpers {
const TypeVariableCheckedModeHelper('assertSubtypeOfRuntimeType'),
const PropertyCheckedModeHelper('propertyTypeCast'),
const PropertyCheckedModeHelper('propertyTypeCheck'),
+ const FunctionTypeRepresentationCheckedModeHelper('functionTypeCast'),
+ const FunctionTypeRepresentationCheckedModeHelper('functionTypeCheck'),
];
// Checked mode helpers indexed by name.
@@ -212,7 +229,9 @@ class CheckedModeHelpers {
: 'assertSubtypeOfRuntimeType';
}
- if (type.isFunctionType) return null;
+ if (type.isFunctionType) {
+ return typeCast ? 'functionTypeCast' : 'functionTypeCheck';
+ }
assert(invariant(NO_LOCATION_SPANNABLE, type.isInterfaceType,
message: "Unexpected type: $type"));

Powered by Google App Engine
This is Rietveld 408576698