Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/compiler/lib/src/js_backend/backend_helpers.dart

Issue 2722753002: Remove HRuntimeType implementation (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend_helpers.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend_helpers.dart b/pkg/compiler/lib/src/js_backend/backend_helpers.dart
index 088c4de4d65aee2af298576129a765aa5f96a829..66251fc4d560b9e58c1824d9573738491a988c7c 100644
--- a/pkg/compiler/lib/src/js_backend/backend_helpers.dart
+++ b/pkg/compiler/lib/src/js_backend/backend_helpers.dart
@@ -612,6 +612,9 @@ class BackendHelpers {
FunctionEntity get subtypeCast => _findHelperFunction('subtypeCast');
+ FunctionEntity get functionTypeTest =>
floitsch 2017/03/02 13:43:38 It feels fishy that the helper is in no impact. It
+ _findHelperFunction('functionTypeTest');
+
FunctionEntity get checkSubtypeOfRuntimeType =>
_findHelperFunction('checkSubtypeOfRuntimeType');
@@ -710,45 +713,6 @@ class BackendHelpers {
ClassEntity get VoidRuntimeType => _findHelperClass('VoidRuntimeType');
- ClassEntity get RuntimeType => _findHelperClass('RuntimeType');
-
- ClassEntity get RuntimeFunctionType =>
- _findHelperClass('RuntimeFunctionType');
-
- ClassEntity get RuntimeTypePlain => _findHelperClass('RuntimeTypePlain');
-
- ClassEntity get RuntimeTypeGeneric => _findHelperClass('RuntimeTypeGeneric');
-
- ClassEntity get DynamicRuntimeType => _findHelperClass('DynamicRuntimeType');
-
- FunctionEntity get getDynamicRuntimeType {
- // TODO(johnniwinther): Support this in mocks.
- return _env.lookupLibraryMember(jsHelperLibrary, 'getDynamicRuntimeType');
- }
-
- FunctionEntity get getVoidRuntimeType {
- // TODO(johnniwinther): Support this in mocks.
- return _env.lookupLibraryMember(jsHelperLibrary, 'getVoidRuntimeType');
- }
-
- FunctionEntity get buildInterfaceType {
- // TODO(johnniwinther): Support this in mocks.
- return _env.lookupLibraryMember(jsHelperLibrary, 'buildInterfaceType');
- }
-
- FunctionEntity get buildFunctionType {
- // TODO(johnniwinther): Support this in mocks.
- return _env.lookupLibraryMember(jsHelperLibrary, 'buildFunctionType');
- }
-
- FunctionEntity get buildNamedFunctionType {
- // TODO(johnniwinther): Support this in mocks.
- return _env.lookupLibraryMember(jsHelperLibrary, 'buildNamedFunctionType');
- }
-
- FunctionEntity get functionTypeTestMetaHelper =>
- _findHelperFunction('functionTypeTestMetaHelper');
-
FunctionEntity get defineProperty => _findHelperFunction('defineProperty');
FunctionEntity get startRootIsolate =>

Powered by Google App Engine
This is Rietveld 408576698