Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2722753002: Remove HRuntimeType implementation (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_helpers.impact; 5 library dart2js.js_helpers.impact;
6 6
7 import '../common/names.dart'; 7 import '../common/names.dart';
8 import '../compiler.dart' show Compiler; 8 import '../compiler.dart' show Compiler;
9 import '../core_types.dart' show CommonElements; 9 import '../core_types.dart' show CommonElements;
10 import '../elements/resolution_types.dart' show ResolutionInterfaceType; 10 import '../elements/resolution_types.dart' show ResolutionInterfaceType;
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 496
497 BackendImpact get typeVariableCheckedModeTypeCheck { 497 BackendImpact get typeVariableCheckedModeTypeCheck {
498 return _typeVariableCheckedModeTypeCheck ??= 498 return _typeVariableCheckedModeTypeCheck ??=
499 new BackendImpact(staticUses: [helpers.assertSubtypeOfRuntimeType]); 499 new BackendImpact(staticUses: [helpers.assertSubtypeOfRuntimeType]);
500 } 500 }
501 501
502 BackendImpact _functionTypeCheck; 502 BackendImpact _functionTypeCheck;
503 503
504 BackendImpact get functionTypeCheck { 504 BackendImpact get functionTypeCheck {
505 return _functionTypeCheck ??= 505 return _functionTypeCheck ??=
506 new BackendImpact(staticUses: [helpers.functionTypeTestMetaHelper]); 506 new BackendImpact(staticUses: [/*helpers.functionTypeTestMetaHelper*/]);
floitsch 2017/03/02 13:43:38 Please add a comment explaining why the dead code
507 } 507 }
508 508
509 BackendImpact _nativeTypeCheck; 509 BackendImpact _nativeTypeCheck;
510 510
511 BackendImpact get nativeTypeCheck { 511 BackendImpact get nativeTypeCheck {
512 return _nativeTypeCheck ??= new BackendImpact(staticUses: [ 512 return _nativeTypeCheck ??= new BackendImpact(staticUses: [
513 // We will neeed to add the "$is" and "$as" properties on the 513 // We will neeed to add the "$is" and "$as" properties on the
514 // JavaScript object prototype, so we make sure 514 // JavaScript object prototype, so we make sure
515 // [:defineProperty:] is compiled. 515 // [:defineProperty:] is compiled.
516 helpers.defineProperty 516 helpers.defineProperty
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 728
729 BackendImpact _staticClosure; 729 BackendImpact _staticClosure;
730 730
731 /// Backend impact for performing closurization of a top-level or static 731 /// Backend impact for performing closurization of a top-level or static
732 /// function. 732 /// function.
733 BackendImpact get staticClosure { 733 BackendImpact get staticClosure {
734 return _staticClosure ??= 734 return _staticClosure ??=
735 new BackendImpact(globalClasses: [helpers.closureClass]); 735 new BackendImpact(globalClasses: [helpers.closureClass]);
736 } 736 }
737 } 737 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698