Addressing UX regression on Win10 FRE, and changing timeout behavior

chrome/browser/resources/welcome/win10/inline.css

Index: chrome/browser/resources/welcome/win10/inline.css
diff --git a/chrome/browser/resources/welcome/win10/inline.css b/chrome/browser/resources/welcome/win10/inline.css
index ac9ce1342c67ca97112247495da11be18e1f720d..1b4ad1d84dd99cc7e43981843b7c4b199ce9c7aa 100644
--- a/chrome/browser/resources/welcome/win10/inline.css
+++ b/chrome/browser/resources/welcome/win10/inline.css
@@ -15,6 +15,7 @@ body {
 
 a {
   color: var(--google-blue-500);
+  cursor: pointer;

[tommycli, 2017/02/27 23:17:22]

Hey, this shouldn't be necessary, since the action-link definitions should take
care of it:

https://cs.chromium.org/chromium/src/ui/webui/resources/css/action_link.css?q...

Looking on inspector, it looks like the action_link css isn't working on this
element.

This is how we normally apply imported styles in HTML imports:

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printi...

Also we generally prefer to inline styles these days rather than in a separate
file. (see above example)

Out of curiosity, how is inline.css even imported in? I don't see a reference to
it in inline.html

[tmartino, 2017/02/28 00:08:53]

Hmm, so I tried creating a <style> and found that it doesn't solve the cursor
issue. Interestingly it looks like the action_link JS is running--role=link is
getting added in all the right places--so it's just the css portion that's
broken. I suspect we should really change this whole page to a dom-module, but
I'm not familiar enough with Polymer to say for sure if that's at fault here.

I'm definitely happy to make that change and to inline the CSS--I'd prefer it
that way anyway--but in terms of a safe merge I'd be more comfortable making a
big restructuring change that way in a followup for M58. WDYT?
There are two layouts, inline.* and combined.*. Depending on a variations
feature, one of them is chosen by the UI class in C++land, and gets loaded as
welcome.*.

[tommycli, 2017/02/28 01:06:28]

I'm okay with fixing this up in a followup. Do you mind adding a TODO?

   text-decoration: none;
 }