Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2722613004: Add documentation for mutating operations of unmodifiable maps. (Closed)

Created:
3 years, 9 months ago by floitsch
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add documentation for mutating operations of unmodifiable maps. Simply states that the operation is not supported. Fixed #28918 BUG= http://dartbug.com/28918 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/7fa4496e5170b6590d440d6b173afc7c8fdde9b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sdk/lib/collection/maps.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
Same text is used for UnmodifiableListViews.
3 years, 9 months ago (2017-02-28 13:19:42 UTC) #2
Lasse Reichstein Nielsen
lgtm
3 years, 9 months ago (2017-02-28 13:25:40 UTC) #3
floitsch
3 years, 9 months ago (2017-02-28 13:41:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fa4496e5170b6590d440d6b173afc7c8fdde9b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698