Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: runtime/lib/mirrors.cc

Issue 27226003: Do not hide membership of implementation classes in dart:core. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 21000a9a7c705c9582ab568441d843694c0a9119..07029a2e6af5d6917e9b8fcb9a374ff571385156 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -1117,11 +1117,10 @@ DEFINE_NATIVE_ENTRY(LibraryMirror_members, 2) {
entry = entries.GetNext();
if (entry.IsClass()) {
const Class& klass = Class::Cast(entry);
- // We filter out implementation classes like Smi, Mint, Bignum,
- // OneByteString; function signature classes; and dynamic.
+ // We filter out function signature classes and dynamic.
+ // TODO(12478): Should not need to filter out dynamic.
if (!klass.IsCanonicalSignatureClass() &&
- !klass.IsDynamicClass() &&
- !RawObject::IsImplementationClassId(klass.id())) {
+ !klass.IsDynamicClass()) {
type = klass.RareType();
member_mirror = CreateClassMirror(klass,
type,
« no previous file with comments | « no previous file | runtime/lib/mirrors_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698