Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: runtime/vm/native_arguments.h

Issue 27226002: Add back native tracing to optimized code. Tracing natives is an important part of perfromance anal… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_arguments.h
===================================================================
--- runtime/vm/native_arguments.h (revision 28588)
+++ runtime/vm/native_arguments.h (working copy)
@@ -48,10 +48,6 @@
VerifyPointersVisitor::VerifyPointers(); \
Isolate::Current()->heap()->Verify(); \
}
-#define TRACE_NATIVE_CALL(format, name) \
- if (FLAG_trace_natives) { \
- OS::Print("Calling native: " format "\n", name); \
- }
#define DEOPTIMIZE_ALOT \
if (FLAG_deoptimize_alot) { \
DeoptimizeAll(); \
@@ -61,12 +57,16 @@
#define CHECK_STACK_ALIGNMENT { }
#define VERIFY_ON_TRANSITION { }
-#define TRACE_NATIVE_CALL(format, name) { }
#define DEOPTIMIZE_ALOT { }
#endif
+#define TRACE_NATIVE_CALL(format, name) \
+ if (FLAG_trace_natives) { \
+ OS::Print("Calling native: " format "\n", name); \
+ }
+
// Class NativeArguments is used to access arguments passed in from
// generated dart code to a runtime function or a dart library native
// function. It is also used to set the return value if any at the slot
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698