OLD | NEW |
1 # Updating Clang format binaries | 1 # Updating Clang format binaries |
2 | 2 |
3 Instructions on how to update the [clang-format binaries](clang_format.md) that | 3 Instructions on how to update the [clang-format binaries](clang_format.md) that |
4 come with a checkout of Chromium. | 4 come with a checkout of Chromium. |
5 | 5 |
6 ## Prerequisites | 6 ## Prerequisites |
7 | 7 |
8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of | 8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of |
9 building clang-format. You'll also need permissions to upload to the appropriate | 9 building clang-format. You'll also need permissions to upload to the appropriate |
10 google storage bucket. Chromium infrastructure team members have this, and | 10 google storage bucket. Chromium infrastructure team members have this, and |
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
84 libatomic.so.1 which doesn't exist on Precise. | 84 libatomic.so.1 which doesn't exist on Precise. |
85 * Mac: Remember to set `MACOSX_DEPLOYMENT_TARGET` when building! If you get | 85 * Mac: Remember to set `MACOSX_DEPLOYMENT_TARGET` when building! If you get |
86 configure warnings, you may need to install XCode 5 and avoid a goma | 86 configure warnings, you may need to install XCode 5 and avoid a goma |
87 environment. | 87 environment. |
88 | 88 |
89 ## Upload each binary to google storage | 89 ## Upload each binary to google storage |
90 | 90 |
91 Copy the binaries into your chromium checkout (under | 91 Copy the binaries into your chromium checkout (under |
92 `src/buildtools/(win|linux64|mac)/clang-format(.exe?)`). For each binary, you'll | 92 `src/buildtools/(win|linux64|mac)/clang-format(.exe?)`). For each binary, you'll |
93 need to run upload_to_google_storage.py according to the instructions in | 93 need to run upload_to_google_storage.py according to the instructions in |
94 [README.txt](/buildtools/clang_format/README.txt). This will upload the binary | 94 [README.txt](https://chromium.googlesource.com/chromium/buildtools/+/master/clan
g_format/README.txt). |
95 into a publicly accessible google storage bucket, and update `.sha1` file in | 95 This will upload the binary into a publicly accessible google storage bucket, |
96 your Chrome checkout. You'll check in the `.sha1` file (but NOT the clang-format | 96 and update `.sha1` file in your Chrome checkout. You'll check in the `.sha1` |
97 binary) into source control. In order to be able to upload, you'll need write | 97 file (but NOT the clang-format binary) into source control. In order to be able |
98 permission to the bucket -- see the prerequisites. | 98 to upload, you'll need write permission to the bucket -- see the prerequisites. |
99 | 99 |
100 ## Copy the helper scripts and update README.chromium | 100 ## Copy the helper scripts and update README.chromium |
101 | 101 |
102 There are some auxiliary scripts that ought to be kept updated in lockstep with | 102 There are some auxiliary scripts that ought to be kept updated in lockstep with |
103 the clang-format binary. These get copied into | 103 the clang-format binary. These get copied into |
104 third_party/clang_format/scripts in your Chromium checkout. | 104 third_party/clang_format/scripts in your Chromium checkout. |
105 | 105 |
106 The `README.chromium` file ought to be updated with version and date info. | 106 The `README.chromium` file ought to be updated with version and date info. |
107 | 107 |
108 ## Upload a CL according to the following template | 108 ## Upload a CL according to the following template |
109 | 109 |
110 Update clang-format binaries and scripts for all platforms. | 110 Update clang-format binaries and scripts for all platforms. |
111 | 111 |
112 I followed these instructions: | 112 I followed these instructions: |
113 https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_
format_binaries.md | 113 https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_
format_binaries.md |
114 | 114 |
115 The binaries were built at clang revision ####### on ####DATETIME####. | 115 The binaries were built at clang revision ####### on ####DATETIME####. |
116 | 116 |
117 BUG= | 117 BUG= |
118 | 118 |
119 The change should **always** include new `.sha1` files for each platform (we | 119 The change should **always** include new `.sha1` files for each platform (we |
120 want to keep these in lockstep), should **never** include `clang-format` | 120 want to keep these in lockstep), should **never** include `clang-format` |
121 binaries directly. The change should **always** update `README.chromium` | 121 binaries directly. The change should **always** update `README.chromium` |
122 | 122 |
123 clang-format binaries should weigh in at 1.5MB or less. Watch out for size | 123 clang-format binaries should weigh in at 1.5MB or less. Watch out for size |
124 regressions. | 124 regressions. |
OLD | NEW |