Improve handling of duplicate id's for SVG resources

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
index f22b7f9d5926f477c9f736134edbf3ef52b537c5..fb4aded25359582cde6208b93a73c5d844982a60 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h
@@ -63,6 +63,10 @@ class LayoutSVGResourceContainer : public LayoutSVGHiddenContainer {
   }
 
   void idChanged(const AtomicString& oldId, const AtomicString& newId);
+  void detachAllClients(const AtomicString& toId);
+
+  void setRegistered(bool registered) { m_registered = registered; }

[pdr., 2017/02/27 23:06:30]

Nit: to prevent calling this at the wrong time, could you make this private and
friend SVGTreeScopeResources? Also, can you add a comment here about what it
means to register a resource?

[fs, 2017/03/06 20:49:54]

Done.

+  bool isRegistered() const { return m_registered; }
 
   void invalidateCacheAndMarkForLayout(SubtreeLayoutScope* = nullptr);
 
@@ -97,7 +101,6 @@ class LayoutSVGResourceContainer : public LayoutSVGHiddenContainer {
   friend class SVGResourcesCache;
   void addClient(LayoutObject*);
   void removeClient(LayoutObject*);
-  void detachAllClients();
 
   // Track global (markAllClientsForInvalidation) invals to avoid redundant
   // crawls.