third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-addition.html - Issue 2722543002: Improve handling of duplicate id's for SVG resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-addition.html

Issue 2722543002: Improve handling of duplicate id's for SVG resources (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/duplicate-ids.html ('k') | third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-addition-expected.html » ('j') | third_party/WebKit/LayoutTests/svg/custom/duplicate-ids-removal.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/run-after-layout-and-paint.js"></script>

	3 <svg>

	4 <linearGradient id="f">

	5 <stop stop-color="green"/>

	6 </linearGradient>

	7 <rect width="100" height="100" fill="url(#f) orange"/>

	8 </svg>

	9 <script>

	10 runAfterLayoutAndPaint(function() {

	11 const svgNs = 'http://www.w3.org/2000/svg';

	12 let gradient = document.createElementNS(svgNs, 'linearGradient');

	13 let stop = gradient.appendChild(document.createElementNS(svgNs, 'stop'));

	14 stop.setAttribute('stop-color', 'red');

	15 gradient.id = 'f';

	16

	17 let rect = document.querySelector('rect');

	18 document.querySelector('svg').insertBefore(gradient, rect);
	Stephen Chennney 2017/02/27 16:21:22 Another test could be done, where the added elemen Another test could be done, where the added element is the one that should become the new resource. So insert a new one before the existing gradient. fs 2017/02/27 17:47:29 Done. Show quoted text On 2017/02/27 at 16:21:22, Stephen Chennney wrote: > Another test could be done, where the added element is the one that should become the new resource. So insert a new one before the existing gradient. Done.
	19 rect.getBoundingClientRect();

	20 rect.setAttribute('stroke-width', 0);
	Stephen Chennney 2017/02/27 16:21:22 Why do you do this? Invalidation bug? Why do you do this? Invalidation bug? fs 2017/02/27 17:47:29 This is here to trigger style-recalc. (Needed to m Show quoted text On 2017/02/27 at 16:21:22, Stephen Chennney wrote: > Why do you do this? Invalidation bug? This is here to trigger style-recalc. (Needed to make this fail on current master. AKA: "pushing the right buttons")
	21 }, true);

	22 </script>

OLD	NEW