Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2722503003: Compute correct parent and fileUri for top-level fields. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A pkg/front_end/test/fasta/function_in_field.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/function_in_field.dart.direct.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/function_in_field.dart.outline.expect View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-02-27 09:17:35 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-02-27 10:57:32 UTC) #3
ahe
3 years, 9 months ago (2017-02-27 12:11:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ed2a5bc8b480b47610a44067a368ffed0a5f4da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698