Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/js-builtin-reducer.cc

Issue 2722483003: [turbofan] Introduce dedicated ObjectIsNaN operator. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/js-builtin-reducer.cc
diff --git a/src/compiler/js-builtin-reducer.cc b/src/compiler/js-builtin-reducer.cc
index a9af93c80ce9cb6e661d72ab5ff189ca6aa49884..914395ade5224a6798f69b01962d2568952927c8 100644
--- a/src/compiler/js-builtin-reducer.cc
+++ b/src/compiler/js-builtin-reducer.cc
@@ -1415,14 +1415,10 @@ Reduction JSBuiltinReducer::ReduceNumberIsInteger(Node* node) {
// ES6 section 20.1.2.4 Number.isNaN ( number )
Reduction JSBuiltinReducer::ReduceNumberIsNaN(Node* node) {
JSCallReduction r(node);
- if (r.InputsMatchOne(Type::Number())) {
- // Number.isNaN(a:number) -> BooleanNot(NumberEqual(a, a))
- Node* input = r.GetJSCallInput(0);
- Node* check = graph()->NewNode(simplified()->NumberEqual(), input, input);
- Node* value = graph()->NewNode(simplified()->BooleanNot(), check);
- return Replace(value);
- }
- return NoChange();
+ // Number.isNaN(a:number) -> ObjectIsNaN(a)
+ Node* input = r.GetJSCallInput(0);
+ Node* value = graph()->NewNode(simplified()->ObjectIsNaN(), input);
+ return Replace(value);
}
// ES6 section 20.1.2.5 Number.isSafeInteger ( number )

Powered by Google App Engine
This is Rietveld 408576698