extensions/renderer/native_extension_bindings_system.cc - Issue 2722463006: [Extensions Bindings] Notify of event unregistration on invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/native_extension_bindings_system.cc

Issue 2722463006: [Extensions Bindings] Notify of event unregistration on invalidation (Closed)

Patch Set: nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/native_extension_bindings_system.cc

diff --git a/extensions/renderer/native_extension_bindings_system.cc b/extensions/renderer/native_extension_bindings_system.cc

index b8aa63d576d726e32b98f55496033969d85bd00c..7f0889763480ae25051ed8e50cdc71d2eff73b35 100644

--- a/extensions/renderer/native_extension_bindings_system.cc

+++ b/extensions/renderer/native_extension_bindings_system.cc

@@ -343,7 +343,10 @@ void NativeExtensionBindingsSystem::DidCreateScriptContext(

ScriptContext* context) {}

void NativeExtensionBindingsSystem::WillReleaseScriptContext(

- ScriptContext* context) {}

+ ScriptContext* context) {

+ v8::HandleScope handle_scope(context->isolate());

+ api_system_.WillReleaseContext(context->v8_context());

void NativeExtensionBindingsSystem::UpdateBindingsForContext(

ScriptContext* context) {