[Extensions Bindings] Notify of event unregistration on invalidation

extensions/renderer/api_event_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_API_EVENT_HANDLER_H_
 #define EXTENSIONS_RENDERER_API_EVENT_HANDLER_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 30 matching lines @@
   // Notifies all listeners of the event with the given |event_name| in the
   // specified |context|, sending the included |arguments|.
   void FireEventInContext(const std::string& event_name,
                           v8::Local<v8::Context> context,
                           const base::ListValue& arguments);
 
   // Returns the EventListeners for a given |event_name| and |context|.
   size_t GetNumEventListenersForTesting(const std::string& event_name,
                                         v8::Local<v8::Context> context);
 
+  // Invalidates listeners for the given |context|. It's a shame we have to
+  // have this separately (as opposed to hooking into e.g. a PerContextData
+  // destructor), but we need to do this before the context is fully removed.

[jbroman, 2017/03/01 17:49:47]

Because it's gone from the ScriptContextSet, right?

[Devlin, 2017/03/01 19:03:50]

Correct (and the ScriptContext wrapper is deleted); extended the comment.

+  void InvalidateContext(v8::Local<v8::Context> context);
+
  private:
   // Method to run a given v8::Function. Curried in for testing.
   binding::RunJSFunction call_js_;
 
   EventListenersChangedMethod listeners_changed_;
 
   DISALLOW_COPY_AND_ASSIGN(APIEventHandler);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_API_EVENT_HANDLER_H_