s390: optimize for int 64-bit operation and cleanup

src/s390/simulator-s390.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 #include <stdlib.h>
 #include <cmath>
 
 #if V8_TARGET_ARCH_S390
 
@@ skipping 8751 matching lines @@
   return 0;
 }
 
 EVALUATE(DEBR) {
   DCHECK_OPCODE(DEBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   float fr1_val = get_float32_from_d_register(r1);
   float fr2_val = get_float32_from_d_register(r2);
   fr1_val /= fr2_val;
   set_d_register_from_float32(r1, fr1_val);
-  SetS390ConditionCode<float>(fr1_val, 0);
-
   return length;
 }
 
 EVALUATE(MAEBR) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(MSEBR) {
@@ skipping 79 matching lines @@
   return 0;
 }
 
 EVALUATE(MEEBR) {
   DCHECK_OPCODE(MEEBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   float fr1_val = get_float32_from_d_register(r1);
   float fr2_val = get_float32_from_d_register(r2);
   fr1_val *= fr2_val;
   set_d_register_from_float32(r1, fr1_val);
-  SetS390ConditionCode<float>(fr1_val, 0);
   return length;
 }
 
 EVALUATE(KDBR) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(CDBR) {
@@ skipping 31 matching lines @@
   return length;
 }
 
 EVALUATE(MDBR) {
   DCHECK_OPCODE(MDBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   double r1_val = get_double_from_d_register(r1);
   double r2_val = get_double_from_d_register(r2);
   r1_val *= r2_val;
   set_d_register_from_double(r1, r1_val);
-  SetS390ConditionCode<double>(r1_val, 0);
   return length;
 }
 
 EVALUATE(DDBR) {
   DCHECK_OPCODE(DDBR);
   DECODE_RRE_INSTRUCTION(r1, r2);
   double r1_val = get_double_from_d_register(r1);
   double r2_val = get_double_from_d_register(r2);
   r1_val /= r2_val;
   set_d_register_from_double(r1, r1_val);
-  SetS390ConditionCode<double>(r1_val, 0);
   return length;
 }
 
 EVALUATE(MADBR) {
   DCHECK_OPCODE(MADBR);
   DECODE_RRD_INSTRUCTION(r1, r2, r3);
   double r1_val = get_double_from_d_register(r1);
   double r2_val = get_double_from_d_register(r2);
   double r3_val = get_double_from_d_register(r3);
   r1_val += r2_val * r3_val;
@@ skipping 1481 matching lines @@
   DCHECK_OPCODE(DLGR);
 #ifdef V8_TARGET_ARCH_S390X
   DECODE_RRE_INSTRUCTION(r1, r2);
   uint64_t r1_val = get_register(r1);
   uint64_t r2_val = get_register(r2);
   DCHECK(r1 % 2 == 0);
   unsigned __int128 dividend = static_cast<unsigned __int128>(r1_val) << 64;
   dividend += get_register(r1 + 1);
   uint64_t remainder = dividend % r2_val;
   uint64_t quotient = dividend / r2_val;
-  r1_val = remainder;
   set_register(r1, remainder);
   set_register(r1 + 1, quotient);
   return length;
 #else
+  // 32 bit arch doesn't support __int128 type
+  USE(instr);
   UNREACHABLE();
+  return 0;
 #endif
 }
 
 EVALUATE(ALCGR) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(SLBGR) {
@@ skipping 465 matching lines @@
   return 0;
 }
 
 EVALUATE(AG) {
   DCHECK_OPCODE(AG);
   DECODE_RXY_A_INSTRUCTION(r1, x2, b2, d2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t alu_out = get_register(r1);
   int64_t mem_val = ReadDW(b2_val + x2_val + d2);
+  bool isOF = CheckOverflowForIntAdd(alu_out, mem_val, int64_t);
   alu_out += mem_val;
-  SetS390ConditionCode<int32_t>(alu_out, 0);
+  SetS390ConditionCode<int64_t>(alu_out, 0);
+  SetS390OverflowCode(isOF);
   set_register(r1, alu_out);
   return length;
 }
 
 EVALUATE(SG) {
   DCHECK_OPCODE(SG);
   DECODE_RXY_A_INSTRUCTION(r1, x2, b2, d2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t alu_out = get_register(r1);
   int64_t mem_val = ReadDW(b2_val + x2_val + d2);
+  bool isOF = CheckOverflowForIntSub(alu_out, mem_val, int64_t);
   alu_out -= mem_val;
   SetS390ConditionCode<int32_t>(alu_out, 0);
+  SetS390OverflowCode(isOF);
   set_register(r1, alu_out);
   return length;
 }
 
 EVALUATE(ALG) {
   DCHECK_OPCODE(ALG);
 #ifndef V8_TARGET_ARCH_S390X
   DCHECK(false);
 #endif
   DECODE_RXY_A_INSTRUCTION(r1, x2, b2, d2);
@@ skipping 33 matching lines @@
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   intptr_t d2_val = d2;
   int64_t mem_val = ReadDW(b2_val + d2_val + x2_val);
   int64_t r1_val = get_register(r1);
   set_register(r1, mem_val * r1_val);
   return length;
 }
 
 EVALUATE(DSG) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(DSG);
+  DECODE_RXY_A_INSTRUCTION(r1, x2, b2, d2);
+  DCHECK(r1 % 2 == 0);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  intptr_t d2_val = d2;
+  int64_t mem_val = ReadDW(b2_val + d2_val + x2_val);
+  int64_t r1_val = get_register(r1 + 1);
+  int64_t quotient = r1_val / mem_val;
+  int64_t remainder = r1_val % mem_val;
+  set_register(r1, remainder);
+  set_register(r1 + 1, quotient);
+  return length;
 }
 
 EVALUATE(CVBG) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(LT) {
   DCHECK_OPCODE(LT);
@@ skipping 587 matching lines @@
   return 0;
 }
 
 EVALUATE(MLG) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(DLG) {
-  UNIMPLEMENTED();
+  DCHECK_OPCODE(DLG);
+#ifdef V8_TARGET_ARCH_S390X
+  DECODE_RXY_A_INSTRUCTION(r1, x2, b2, d2);
+  uint64_t r1_val = get_register(r1);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  DCHECK(r1 % 2 == 0);
+  unsigned __int128 dividend = static_cast<unsigned __int128>(r1_val) << 64;
+  dividend += get_register(r1 + 1);
+  int64_t mem_val = ReadDW(b2_val + x2_val + d2);
+  uint64_t remainder = dividend % mem_val;
+  uint64_t quotient = dividend / mem_val;
+  set_register(r1, remainder);
+  set_register(r1 + 1, quotient);
+  return length;
+#else
+  // 32 bit arch doesn't support __int128 type
   USE(instr);
+  UNREACHABLE();
   return 0;
+#endif
 }
 
 EVALUATE(ALCG) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(SLBG) {
   UNIMPLEMENTED();
@@ skipping 882 matching lines @@
 }
 
 EVALUATE(CIB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(LDEB) {
   DCHECK_OPCODE(LDEB);
-  // Load Float
   DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
   int rb = b2;
   int rx = x2;
   int offset = d2;
   int64_t rb_val = (rb == 0) ? 0 : get_register(rb);
   int64_t rx_val = (rx == 0) ? 0 : get_register(rx);
-  double ret =
-      static_cast<double>(*reinterpret_cast<float*>(rx_val + rb_val + offset));
-  set_d_register_from_double(r1, ret);
+  float fval = ReadFloat(rx_val + rb_val + offset);
+  set_d_register_from_double(r1, static_cast<double>(fval));
   return length;
 }
 
 EVALUATE(LXDB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(LXEB) {
@@ skipping 21 matching lines @@
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   intptr_t d2_val = d2;
   float r1_val = get_float32_from_d_register(r1);
   float fval = ReadFloat(b2_val + x2_val + d2_val);
   SetS390ConditionCode<float>(r1_val, fval);
   return length;
 }
 
 EVALUATE(AEB) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(AEB);
+  DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  intptr_t d2_val = d2;
+  float r1_val = get_float32_from_d_register(r1);
+  float fval = ReadFloat(b2_val + x2_val + d2_val);
+  r1_val += fval;
+  set_d_register_from_float32(r1, r1_val);
+  SetS390ConditionCode<float>(r1_val, 0);
+  return length;
 }
 
 EVALUATE(SEB) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(SEB);
+  DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  intptr_t d2_val = d2;
+  float r1_val = get_float32_from_d_register(r1);
+  float fval = ReadFloat(b2_val + x2_val + d2_val);
+  r1_val -= fval;
+  set_d_register_from_float32(r1, r1_val);
+  SetS390ConditionCode<float>(r1_val, 0);
+  return length;
 }
 
 EVALUATE(MDEB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(DEB) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(DEB);
+  DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  intptr_t d2_val = d2;
+  float r1_val = get_float32_from_d_register(r1);
+  float fval = ReadFloat(b2_val + x2_val + d2_val);
+  r1_val /= fval;
+  set_d_register_from_float32(r1, r1_val);
+  return length;
 }
 
 EVALUATE(MAEB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(MSEB) {
   UNIMPLEMENTED();
@@ skipping 32 matching lines @@
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   intptr_t d2_val = d2;
   double r1_val = get_double_from_d_register(r1);
   double dbl_val = ReadDouble(b2_val + x2_val + d2_val);
   r1_val = std::sqrt(dbl_val);
   set_d_register_from_double(r1, r1_val);
   return length;
 }
 
 EVALUATE(MEEB) {
-  UNIMPLEMENTED();
-  USE(instr);
-  return 0;
+  DCHECK_OPCODE(MEEB);
+  DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
+  int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
+  int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
+  intptr_t d2_val = d2;
+  float r1_val = get_float32_from_d_register(r1);
+  float fval = ReadFloat(b2_val + x2_val + d2_val);
+  r1_val *= fval;
+  set_d_register_from_float32(r1, r1_val);
+  return length;
 }
 
 EVALUATE(KDB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(CDB) {
   DCHECK_OPCODE(CDB);
@@ skipping 40 matching lines @@
 EVALUATE(MDB) {
   DCHECK_OPCODE(MDB);
   DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   intptr_t d2_val = d2;
   double r1_val = get_double_from_d_register(r1);
   double dbl_val = ReadDouble(b2_val + x2_val + d2_val);
   r1_val *= dbl_val;
   set_d_register_from_double(r1, r1_val);
-  SetS390ConditionCode<double>(r1_val, 0);
   return length;
 }
 
 EVALUATE(DDB) {
   DCHECK_OPCODE(DDB);
   DECODE_RXE_INSTRUCTION(r1, b2, x2, d2);
   int64_t b2_val = (b2 == 0) ? 0 : get_register(b2);
   int64_t x2_val = (x2 == 0) ? 0 : get_register(x2);
   intptr_t d2_val = d2;
   double r1_val = get_double_from_d_register(r1);
   double dbl_val = ReadDouble(b2_val + x2_val + d2_val);
   r1_val /= dbl_val;
   set_d_register_from_double(r1, r1_val);
-  SetS390ConditionCode<double>(r1_val, 0);
   return length;
 }
 
 EVALUATE(MADB) {
   UNIMPLEMENTED();
   USE(instr);
   return 0;
 }
 
 EVALUATE(MSDB) {
@@ skipping 134 matching lines @@
   return 0;
 }
 
 #undef EVALUATE
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // USE_SIMULATOR
 #endif  // V8_TARGET_ARCH_S390