Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: services/file/file_service.h

Issue 2722293002: Fix lifetime of leveldb::MojoEnv instances. (Closed)
Patch Set: annotate leaks Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/file/file_service.h
diff --git a/services/file/file_service.h b/services/file/file_service.h
index c91490a69f69e5d8300f187b631c85ba0c4eb4f2..e01fd6a3de859d09bbc99246cdb703a70d40a2fa 100644
--- a/services/file/file_service.h
+++ b/services/file/file_service.h
@@ -15,10 +15,14 @@
#include "services/service_manager/public/cpp/interface_factory.h"
#include "services/service_manager/public/cpp/service.h"
+namespace leveldb {
+class MojoEnv;
+}
+
namespace file {
std::unique_ptr<service_manager::Service> CreateFileService(
- scoped_refptr<base::SingleThreadTaskRunner> file_service_runner,
+ leveldb::MojoEnv* leveldb_env,
scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner);
class FileService
@@ -27,7 +31,7 @@ class FileService
public service_manager::InterfaceFactory<leveldb::mojom::LevelDBService> {
public:
FileService(
- scoped_refptr<base::SingleThreadTaskRunner> file_service_runner,
+ leveldb::MojoEnv* leveldb_env,
scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner);
~FileService() override;
@@ -48,6 +52,7 @@ class FileService
void OnLevelDBServiceError();
+ leveldb::MojoEnv* leveldb_env_;
scoped_refptr<base::SingleThreadTaskRunner> file_service_runner_;
scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner_;

Powered by Google App Engine
This is Rietveld 408576698