Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: components/leveldb/leveldb_database_impl.cc

Issue 2722293002: Fix lifetime of leveldb::MojoEnv instances. (Closed)
Patch Set: annotate leaks Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/leveldb/leveldb_database_impl.cc
diff --git a/components/leveldb/leveldb_database_impl.cc b/components/leveldb/leveldb_database_impl.cc
index 5387409d2d4b055f526d2ec0c7d58eb4658751db..4eecfe9a935a36def417c8d155fedc24ac6d5fd1 100644
--- a/components/leveldb/leveldb_database_impl.cc
+++ b/components/leveldb/leveldb_database_impl.cc
@@ -34,10 +34,14 @@ leveldb::Status ForEachWithPrefix(leveldb::DB* db,
} // namespace
+LevelDBDatabaseImpl::LevelDBDatabaseImpl(std::unique_ptr<Env> owned_environment,
+ std::unique_ptr<DB> db)
+ : owned_environment_(std::move(owned_environment)), db_(std::move(db)) {}
+
LevelDBDatabaseImpl::LevelDBDatabaseImpl(
- std::unique_ptr<leveldb::Env> environment,
+ std::unique_ptr<MojoEnv::Directory> directory,
std::unique_ptr<leveldb::DB> db)
- : environment_(std::move(environment)), db_(std::move(db)) {}
+ : directory_(std::move(directory)), db_(std::move(db)) {}
LevelDBDatabaseImpl::~LevelDBDatabaseImpl() {
for (auto& p : iterator_map_)

Powered by Google App Engine
This is Rietveld 408576698