Fix lifetime of leveldb::MojoEnv instances.

services/file/file_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/file/file_service.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/weak_ptr.h"
 #include "components/filesystem/lock_table.h"
+#include "components/leveldb/env_mojo.h"
 #include "components/leveldb/leveldb_service_impl.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "services/file/file_system.h"
 #include "services/file/user_id_map.h"
 #include "services/service_manager/public/cpp/connection.h"
 #include "services/service_manager/public/cpp/service_context.h"
 
 namespace file {
 
 class FileService::FileSystemObjects
@@ skipping 19 matching lines @@
   scoped_refptr<filesystem::LockTable> lock_table_;
   base::FilePath user_dir_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemObjects);
 };
 
 class FileService::LevelDBServiceObjects
     : public base::SupportsWeakPtr<LevelDBServiceObjects> {
  public:
   // Created on the main thread.
-  LevelDBServiceObjects(
-      scoped_refptr<base::SingleThreadTaskRunner> file_task_runner)
-      : file_task_runner_(std::move(file_task_runner)) {}
+  LevelDBServiceObjects(leveldb::MojoEnv* env) : env_(env) {}
 
   // Destroyed on the |leveldb_service_runner_|.
   ~LevelDBServiceObjects() {}
 
   // Called on the |leveldb_service_runner_|.
   void OnLevelDBServiceRequest(const service_manager::Identity& remote_identity,
                                leveldb::mojom::LevelDBServiceRequest request) {
     if (!leveldb_service_)
-      leveldb_service_.reset(
-          new leveldb::LevelDBServiceImpl(file_task_runner_));
+      leveldb_service_.reset(new leveldb::LevelDBServiceImpl(env_));
     leveldb_bindings_.AddBinding(leveldb_service_.get(), std::move(request));
   }
 
  private:
-  scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
-
   // Variables that are only accessible on the |leveldb_service_runner_| thread.
   std::unique_ptr<leveldb::mojom::LevelDBService> leveldb_service_;
   mojo::BindingSet<leveldb::mojom::LevelDBService> leveldb_bindings_;
 
+  leveldb::MojoEnv* env_;
+
   DISALLOW_COPY_AND_ASSIGN(LevelDBServiceObjects);
 };
 
 std::unique_ptr<service_manager::Service> CreateFileService(
-    scoped_refptr<base::SingleThreadTaskRunner> file_service_runner,
+    leveldb::MojoEnv* leveldb_env,
     scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner) {
-  return base::MakeUnique<FileService>(std::move(file_service_runner),
+  return base::MakeUnique<FileService>(leveldb_env,
                                        std::move(leveldb_service_runner));
 }
 
 FileService::FileService(
-    scoped_refptr<base::SingleThreadTaskRunner> file_service_runner,
+    leveldb::MojoEnv* leveldb_env,
     scoped_refptr<base::SingleThreadTaskRunner> leveldb_service_runner)
-    : file_service_runner_(std::move(file_service_runner)),
+    : leveldb_env_(leveldb_env),
       leveldb_service_runner_(std::move(leveldb_service_runner)) {
   registry_.AddInterface<leveldb::mojom::LevelDBService>(this);
   registry_.AddInterface<mojom::FileSystem>(this);
 }
 
 FileService::~FileService() {
-  file_service_runner_->DeleteSoon(FROM_HERE, file_system_objects_.release());
+  leveldb_env_->file_task_runner()->DeleteSoon(FROM_HERE,
+                                               file_system_objects_.release());
   leveldb_service_runner_->DeleteSoon(FROM_HERE, leveldb_objects_.release());
 }
 
 void FileService::OnStart() {
   file_system_objects_.reset(new FileService::FileSystemObjects(
       GetUserDirForUserId(context()->identity().user_id())));
-  leveldb_objects_.reset(
-      new FileService::LevelDBServiceObjects(file_service_runner_));
+  leveldb_objects_.reset(new FileService::LevelDBServiceObjects(leveldb_env_));
 }
 
 void FileService::OnBindInterface(
     const service_manager::ServiceInfo& source_info,
     const std::string& interface_name,
     mojo::ScopedMessagePipeHandle interface_pipe) {
   registry_.BindInterface(source_info.identity, interface_name,
                           std::move(interface_pipe));
 }
 
 void FileService::Create(const service_manager::Identity& remote_identity,
                          mojom::FileSystemRequest request) {
-  file_service_runner_->PostTask(
+  leveldb_env_->file_task_runner()->PostTask(
       FROM_HERE,
       base::Bind(&FileService::FileSystemObjects::OnFileSystemRequest,
                  file_system_objects_->AsWeakPtr(), remote_identity,
                  base::Passed(&request)));
 }
 
 void FileService::Create(const service_manager::Identity& remote_identity,
                          leveldb::mojom::LevelDBServiceRequest request) {
   leveldb_service_runner_->PostTask(
       FROM_HERE,
       base::Bind(
           &FileService::LevelDBServiceObjects::OnLevelDBServiceRequest,
           leveldb_objects_->AsWeakPtr(), remote_identity,
           base::Passed(&request)));
 }
 
 }  // namespace user_service