Initial implementation of interpreter for Kernel

Initial implementation of interpreter for Kernel

Basic framework, evaluation of BasicLiterals and dummy evaluation
of print.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/1b82e0c3a0d8c8fedf47d365f5d4c25a8cd186c8

[zhivkag, 2017-03-02 09:56:48]

zhivkag@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-03-02 10:30:30]

LGTM.  I suggest making the one-argument visitor a little more generic and
moving it into visitor.dart.  Feel free to make that a separate change.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/bin/eval.dart
File pkg/kernel/bin/eval.dart (right):

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/bin/eval.dart#ne...
pkg/kernel/bin/eval.dart:2: // Copyright (c) 2016, the Dart project authors. 
Please see the AUTHORS file
2017

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/bin/eval.dart#ne...
pkg/kernel/bin/eval.dart:20: return fail('One input binary file shoud be
specified.');
shoud ==> should

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/ast.dart
File pkg/kernel/lib/ast.dart (right):

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/ast.dart#new...
pkg/kernel/lib/ast.dart:1412: accept1(ExpressionVisitor1 v, State s);
I'd change this to:

accept1(ExpressionVisitor1 v, arg);

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:1: // Copyright (c) 2016, the Dart
project authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:8: import
'interpreter_visitor.dart';
This is already exported by ast.dart.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:30: Statement statement =
statementBlock.statements[0];
This can be statementBlock.first.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter_visitor.dart (right):

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter_visitor.dart:1: // Copyright 1(c) 2016,
the Dart project authors.  Please see the AUTHORS file
2017.  A 1 (or maybe an L) has also crept in here.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter_visitor.dart:11: R
defaultExpression1(Expression node, State state) => null;
We should also generalize all these methods to:

R visitXXX(Expression node, arg) => defaultExpression(node, arg)

Then I'd move this class into visitor.dart.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter_visitor.dart:16: R
visitInvalidExpression1(InvalidExpression node, State state) =>
We need the '1' on ExpressionVisitor1 and accept1 because they have to coexist
with ExpressionVisitor and accept.  I don't think we need it on
visitInvalidExpression, defaultExpression, etc.

I suggest removing it in all those places because it's kind of ugly and easy to
miss.

https://codereview.chromium.org/2722283003/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter_visitor.dart:130: abstract class State {
If we eliminate the type State from the AST and visitor interfaces, we should
eliminate this class.

[zhivkag, 2017-03-02 12:19:40]

Description was changed from

==========
Initial implementation of interpreter for Kernel

Basic framework, evaluation of BasicLiterals and dummy evaluation
of print.

BUG=
==========

to

==========
Initial implementation of interpreter for Kernel

Basic framework, evaluation of BasicLiterals and dummy evaluation
of print.

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1b82e0c3a0d8c8fedf47d365f5d4c25a8cd186c8
==========

[zhivkag, 2017-03-02 12:19:42]

Committed patchset #3 (id:40001) manually as
1b82e0c3a0d8c8fedf47d365f5d4c25a8cd186c8 (presubmit successful).