Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 2722283002: Parse 'x.y' as PrefixedIdentifier, not PropertyAccess with Fasta. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analyzer/dart/ast/ast.dart'; 5 import 'package:analyzer/dart/ast/ast.dart';
6 import 'package:analyzer/dart/ast/token.dart' as analyzer; 6 import 'package:analyzer/dart/ast/token.dart' as analyzer;
7 import 'package:analyzer/dart/element/element.dart'; 7 import 'package:analyzer/dart/element/element.dart';
8 import 'package:analyzer/error/error.dart'; 8 import 'package:analyzer/error/error.dart';
9 import 'package:analyzer/src/generated/parser.dart' as analyzer; 9 import 'package:analyzer/src/generated/parser.dart' as analyzer;
10 import 'package:analyzer/src/generated/utilities_dart.dart'; 10 import 'package:analyzer/src/generated/utilities_dart.dart';
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 @override 278 @override
279 @failingTest 279 @failingTest
280 void test_assignableExpression_arguments_normal_chain_typeArguments() { 280 void test_assignableExpression_arguments_normal_chain_typeArguments() {
281 // TODO(paulberry,ahe): AstBuilder doesn't implement 281 // TODO(paulberry,ahe): AstBuilder doesn't implement
282 // endTypeArguments(). 282 // endTypeArguments().
283 super.test_assignableExpression_arguments_normal_chain_typeArguments(); 283 super.test_assignableExpression_arguments_normal_chain_typeArguments();
284 } 284 }
285 285
286 @override 286 @override
287 @failingTest 287 @failingTest
288 void test_assignmentExpression_prefixedIdentifier() {
289 // TODO(paulberry,ahe): Analyzer expects "x.y" to be parsed as a
290 // PrefixedIdentifier, even if x is not a prefix.
291 super.test_assignmentExpression_prefixedIdentifier();
292 }
293
294 @override
295 @failingTest
296 void test_cascade_withAssignment() { 288 void test_cascade_withAssignment() {
297 // TODO(paulberry,ahe): AstBuilder doesn't implement 289 // TODO(paulberry,ahe): AstBuilder doesn't implement
298 // endConstructorReference(). 290 // endConstructorReference().
299 super.test_cascade_withAssignment(); 291 super.test_cascade_withAssignment();
300 } 292 }
301 293
302 @override 294 @override
303 @failingTest 295 @failingTest
304 void test_conditionalExpression_precedence_nullableType_as() { 296 void test_conditionalExpression_precedence_nullableType_as() {
305 // TODO(paulberry,ahe): Fasta doesn't support NNBD syntax yet. 297 // TODO(paulberry,ahe): Fasta doesn't support NNBD syntax yet.
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 @override 401 @override
410 @failingTest 402 @failingTest
411 void 403 void
412 test_parseAssignableExpression_identifier_args_dot_typeParameterComments() { 404 test_parseAssignableExpression_identifier_args_dot_typeParameterComments() {
413 super 405 super
414 .test_parseAssignableExpression_identifier_args_dot_typeParameterComment s(); 406 .test_parseAssignableExpression_identifier_args_dot_typeParameterComment s();
415 } 407 }
416 408
417 @override 409 @override
418 @failingTest 410 @failingTest
419 void test_parseAssignableExpression_identifier_dot() {
420 super.test_parseAssignableExpression_identifier_dot();
421 }
422
423 @override
424 @failingTest
425 void test_parseAwaitExpression() { 411 void test_parseAwaitExpression() {
426 super.test_parseAwaitExpression(); 412 super.test_parseAwaitExpression();
427 } 413 }
428 414
429 @override 415 @override
430 @failingTest 416 @failingTest
431 void test_parseCascadeSection_ia_typeArgumentComments() { 417 void test_parseCascadeSection_ia_typeArgumentComments() {
432 super.test_parseCascadeSection_ia_typeArgumentComments(); 418 super.test_parseCascadeSection_ia_typeArgumentComments();
433 } 419 }
434 420
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 @override 726 @override
741 @failingTest 727 @failingTest
742 void 728 void
743 test_parsePostfixExpression_none_methodInvocation_typeArgumentComments() { 729 test_parsePostfixExpression_none_methodInvocation_typeArgumentComments() {
744 super 730 super
745 .test_parsePostfixExpression_none_methodInvocation_typeArgumentComments( ); 731 .test_parsePostfixExpression_none_methodInvocation_typeArgumentComments( );
746 } 732 }
747 733
748 @override 734 @override
749 @failingTest 735 @failingTest
750 void test_parsePostfixExpression_none_propertyAccess() {
751 super.test_parsePostfixExpression_none_propertyAccess();
752 }
753
754 @override
755 @failingTest
756 void test_parsePrefixedIdentifier_prefix() {
757 super.test_parsePrefixedIdentifier_prefix();
758 }
759
760 @override
761 @failingTest
762 void test_parsePrimaryExpression_const() { 736 void test_parsePrimaryExpression_const() {
763 super.test_parsePrimaryExpression_const(); 737 super.test_parsePrimaryExpression_const();
764 } 738 }
765 739
766 @override 740 @override
767 @failingTest 741 @failingTest
768 void test_parsePrimaryExpression_listLiteral_typed_genericComment() { 742 void test_parsePrimaryExpression_listLiteral_typed_genericComment() {
769 super.test_parsePrimaryExpression_listLiteral_typed_genericComment(); 743 super.test_parsePrimaryExpression_listLiteral_typed_genericComment();
770 } 744 }
771 745
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 } 907 }
934 908
935 @override 909 @override
936 Expression parseAssignableExpression(String code, bool primaryAllowed) { 910 Expression parseAssignableExpression(String code, bool primaryAllowed) {
937 return _parseExpression(code); 911 return _parseExpression(code);
938 } 912 }
939 913
940 @override 914 @override
941 Expression parseAssignableSelector(String code, bool optional, 915 Expression parseAssignableSelector(String code, bool optional,
942 {bool allowConditional: true}) { 916 {bool allowConditional: true}) {
917 if (optional) {
918 if (code.isEmpty) {
919 return _parseExpression('foo');
920 }
921 return _parseExpression('(foo)$code');
922 }
943 return _parseExpression('foo$code'); 923 return _parseExpression('foo$code');
944 } 924 }
945 925
946 @override 926 @override
947 AwaitExpression parseAwaitExpression(String code) { 927 AwaitExpression parseAwaitExpression(String code) {
948 return _parseExpression(code); 928 return _parseExpression(code);
949 } 929 }
950 930
951 @override 931 @override
952 Expression parseBitwiseAndExpression(String code) { 932 Expression parseBitwiseAndExpression(String code) {
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
1732 void test_parseTypeAlias_genericFunction_typeParameters_voidReturnType() { 1712 void test_parseTypeAlias_genericFunction_typeParameters_voidReturnType() {
1733 super.test_parseTypeAlias_genericFunction_typeParameters_voidReturnType(); 1713 super.test_parseTypeAlias_genericFunction_typeParameters_voidReturnType();
1734 } 1714 }
1735 1715
1736 @override 1716 @override
1737 @failingTest 1717 @failingTest
1738 void test_parseTypeAlias_genericFunction_voidReturnType() { 1718 void test_parseTypeAlias_genericFunction_voidReturnType() {
1739 super.test_parseTypeAlias_genericFunction_voidReturnType(); 1719 super.test_parseTypeAlias_genericFunction_voidReturnType();
1740 } 1720 }
1741 } 1721 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698